{23} Trac comments (3729 matches)

Results (401 - 500 of 3729)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
Ticket Posixtime Author Newvalue
#2576 1340617688000000 aron.carroll Fixed proper in 4bf158b
#2575 1340184557000000 toby @adria, Do you have a url or some more info as I can't reproduce this
#2575 1340188954000000 toby wtf I never added that I did write in an hour ago f****g trac
#2575 1340899487000000 toby This should now have a fix do a proper fix for 1.9 - needs a more thought out approach and quite a bit of re-factoring of that bit of code
#2575 1343216544000000 toby merged for 1.8
#2574 1342008841000000 toby david I think this is a closed as we are using state= draft stuff
#2574 1342092416000000 toby this is all sorted so closing
#2571 1340369783000000 toby this works so closing
#2570 1340107841000000 aron.carroll Closed in a3939a4
#2569 1340123360000000 aron.carroll Templates added in 4e84622 Toby, the implementation in the resource form needs data passing to it. https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/pages/form_page.html#L35-36
#2569 1340362284000000 toby @aron, which page is this on? can you add a url - cheers
#2569 1340375156000000 toby i'm assuming this is the add data part 2 add dataset form
#2569 1340375595000000 shevski Ticket itself is for resource pages, e.g. http://s031.okserver.org:2375/dataset/afterfibre/resource/f5d81da5-2e55-4302-8ed2-58401d2c139e - there are two other resources in that other dataset, should be able to navigate between
#2569 1340376578000000 toby @ira, that's fixed in the dev branch just not pushed to demo we need the one i've suggested too
#2569 1340877069000000 toby There is now the list in the sidebar but it points to view resource not edit - that will be part of phase 2
#2569 1340878031000000 shevski Great! Can we change it so that the resource name (if available) displays instead of the URL?
#2569 1342085235000000 toby edit resources in add dataset is done anything else is a new ticket
#2568 1340108132000000 aron.carroll Fixed in 4d3cd87
#2567 1340120404000000 aron.carroll Fixed in 2564dfd
#2566 1340119694000000 aron.carroll Buttons are added in d15cf6f. Toby could you hook these up with appropriate routes.
#2565 1340116053000000 aron.carroll Social links open in a new tab as of bb41d86
#2564 1340118952000000 aron.carroll Fixed as of df8f82c
#2563 1340106310000000 aron.carroll Done in 73fe36c
#2562 1342090168000000 toby @aron, assigning to you so doesn't get lost let me know if you need anything from me for this
#2562 1352206599000000 johnmartin I'm closing this because I can't get context on this.
#2560 1340617540000000 aron.carroll Clicking "previous" should take you to the last edited resource. Clicking "previous" should take you to the last edited resource but stage 3 should remain active. Clicking "previous" should take you to the last edited resource, clicking next should take you to stage three with the same data as when you went back.
#2560 1342084988000000 toby again closing any problems can be bugfix tickets
#2559 1340617445000000 aron.carroll This is looking good. A couple of things to do. 1. Added resources should be displayed in the sidebar. See https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/pages/form_page.html#L36 2. Clicking "previous" needs to take you back to the add dataset action not the edit dataset action. 3. Clicking "previous" should take you back to stage one of the add dataset form but stage two should be active (green). 4. Clicking "previous" should take you back to stage one of the add dataset form then clicking next should take you to the last resource you were editing.
#2559 1342084940000000 toby I'm closing this now we can open tickets for bugs when we qa the add dataset
#2558 1340188906000000 aron.carroll Started this as of 4d3c87a however tags need to be hooked up (apparently they can only be added on update at the moment). Also by moving the groups to the metadata form I now get integrity errors while saving. Toby could you please take a look at this.
#2558 1340271359000000 toby @aron, not quite sure what your problem was. I had an integrity error on part 1 save which is fixed. my issues 1) part 1 tags not saved 2) part 2 resources not saved 3) part 3 no form shown - i thought you had one showing where did it go? will look at 1 & 2 for starters
#2558 1340280814000000 toby 1) tags save but don't show in dataset edit - will push fix soon
#2558 1340284495000000 toby 2) resources save but not sure if being validated etc needs testing but working to an extent @aron, I'm pushing this back to you now reassign as needed
#2558 1340301273000000 aron.carroll Metadata is back as of b20538f Groups currently aren't showing because the {{{c.groups_available}} param isn't available. https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/new_package_metadata.html#L7
#2558 1340359174000000 toby groups available now is a helper function (templates updated) commit d0506f3
#2558 1340367843000000 toby @aron, metadata now saves pushing back to you - in branch
#2558 1340615257000000 aron.carroll Marking as fixed. Will create new issues as they arise
#2557 1340185609000000 aron.carroll Fixed in 123b914
#2556 1340212090000000 aron.carroll Fixed in 2b3b005
#2555 1340373267000000 toby non urgent moving milestone
#2554 1342518917000000 ross Python based cartridges rely on the virtuoso python hosting, which appears to be broken on my self-built open source version. This is likely to take a lot of time fighting with build setups. Going to delay this.
#2554 1344338036000000 ross Reducing the priority of this at present, may become more relevant after the LOD3 plenary
#2554 1346670433000000 ross Shelved until LOD plenary/funding found. Longer term plans for an LOD hosted triplestore may make this unnecessary.
#2553 1342090078000000 toby different implementation but same effect
#2552 1340626635000000 ross Clarify
#2551 1343042712000000 johnglover All done (in master and release-v1.8 of ckanext-googleanalytics), with the exception of the download and data api buttons which should be tracked already in download stats. Untested, but will probably remain so for the near future at least as this doesn't seem to be a high priority any more.
#2550 1340626589000000 ross Clarify
#2550 1341767370000000 icmurray I've done some initial work on this. I think the best way is to define extra tables in the datahub extension. (Rather than: using groups; or modifying the user table; or defining extras for users (in core)). Initially, I've created a new domain object, PaidService, which captures the different levels of account a user may have. And then attached users to this through a secondary table. I think the advantages of this approach are: - the PaidService table can contain supplementary info about that account type: eg - amount of storage allowed; or cost to sign up etc... - allows us to use a modular payment system if biz decide that would be favourable. ie - users belong to multiple PaidServices which are independant of one another, rather than a linear hierarcy (eg - "sign up for storage, but not for privacy" vs. "sign up for enterprise level rather than basic level") The thing that's held me up today is being able to run tests: I'm having a sqlalchemy issue with defining extra mappings on the User table; which then gets dropped when initializing the test setup. I've gotten to the bottom of the problem, and will ask kindly's advice. In the meantime, I could do with some user stories please. I think I have a fairly good idea of what's likely to be needed by this ticket; but to what extent should this be exposed to a sysadmin (adding payment schemes; adding users to payment schemes; users seeing which payemtn services they're paying for (public to other users or not?); user's seeing history of payments? sysadmins seeing list of users for each service level?) - should this be: through a dashboard? through paster commands? through the api? all 3? Do we want modular payments or a linear hierarchy of payment schemes? How does is this suppossed to fit in with organizations? Do organizations purchase on behalf of users as well as individuals being able to make purchases? Do we need to be able to deativate a user's paid service if their payment hasn't come through?
#2550 1341833460000000 ross I think you've nailed the user stories already, but have added them to Description to be explicit.
#2550 1342535924000000 rgrp Sounds good. BTW all users stories if at all possible go in google docs now for permanence. Here is the template: https://docs.google.com/document/d/1U5yahDrvp_PKQMNjzI_8u3xixnALf4eNZWK2BdTXOVw/edit
#2550 1342699856000000 icmurray Awaiting merge: https://github.com/okfn/ckanext-datahub/pull/1
#2550 1346669497000000 ross Reassigned to icmurray rather than back to backlog.
#2549 1350561840000000 seanh Closing as we've gone forward with a different solution instead
#2548 1340626532000000 ross Accepted to clarify requirements
#2545 1344337973000000 ross Up at http://datagm.ckanhosted.com
#2536 1339770953000000 toby minor changes All links now go to the item - before deleted ones didn't. while this makes sense it is inconsistent and adds complexity. Some wrapping spans eg <span class="object">.. have been removed again these add complication and feel wrong given the issues of i18n PS: why messing with my tickets???
#2536 1340038712000000 toby https://github.com/okfn/ckan/pull/25
#2536 1340899218000000 toby This need some changes to make it possible to add new activity stream bits - will look at doing for 1.9
#2534 1340631124000000 amercader See #2399
#2532 1340874456000000 toby see void now
#2528 1339687025000000 aron.carroll Now implemented as of bc440d5. Doesn't seem to be successfully submitting, has something been setup wrong?
#2528 1340380415000000 toby fixed in 109ec86 what else are we wanting with this?
#2527 1339683264000000 toby Do we have a specific usecase for this?
#2527 1340116130000000 aron.carroll Closing as this has been superceded by #2553
#2523 1339679814000000 aron.carroll Added in 4f6d8b9 Toby, there's no form data being passed to this page yet, could you add that in?
#2523 1340368036000000 toby there and working
#2520 1340624831000000 seanh Also see #2370
#2519 1345565215000000 ross Fixed by pull request from jpmckinney
#2514 1340959630000000 ross I'm going to close this as it is not safely in Aron's hands for the new demo theme.
#2514 1340959787000000 ross s/not/now/ stupid keyboard
#2513 1340187230000000 ross Have pushed back to 1.9 but if may be the the converter service will replace it in the meantime.
#2512 1339576809000000 toby This seems to be working now
#2511 1339517817000000 aron.carroll Fixed in b24d162
#2510 1339516414000000 toby ok I've done this and also unified the tags they are now tag/class {{{ <ul 'tag-list'> <li> <a 'tag'> }}} on home page tag was on <li> not <a> slightly changes the spacing please review
#2510 1339670520000000 aron.carroll Looks okay to me
#2509 1339419867000000 johnglover https://github.com/okfn/ckan/pull/20
#2507 1339436591000000 aron.carroll Fixed as of 2a5714b, pull request here: https://github.com/okfn/ckan/pull/22
#2507 1339596399000000 seanh merged
#2504 1339409776000000 aron.carroll Closing this as there are just snippets remaining now and they're a lower priority.
#2503 1339495333000000 toby @aron, To clarify this a bit. We want this so that a extension can create a new template say dataset/read.html but rather than rewriting the `core` template in ckan it can extend it in the same way as {% extends %}. The main difference is that {% ckan_extends 'template.html' %} would `walk` the ckan template tree rather than the extensions template tree. Is that what we are thinking?
#2503 1339498751000000 aron.carroll Toby yeah, that's exactly it.
#2503 1339580675000000 toby implemented in commit 14067ff
#2502 1339407123000000 toby {% snippet 'template_name', var=value, var2=value ... %} {% url_for(controller='foo', action='bar', ...) %} let me know if you want these changed eg remove need for () in url_for merged into demo branch they are just available in jinja templates no need to do anything special Let me know any problems or if you need some others added
#2502 1339493182000000 aron.carroll Works beautifully. Be great if we could remove the parens around url_for and add an extra one for h.nav_link but I think call it link_for instead. {{{ {% url_for controller='foo', action='bar', ... %} {% link_for controller='foo', action='bar', class='btn', icon='plus'... %} }}}
#2502 1339494853000000 toby url_for no longer needs () link_for added but not tested - pretty certain it will just work
#2498 1339660986000000 toby fixed in the demo branch
#2497 1339085489000000 toby yes is ckan 1.7 issue
#2496 1339418832000000 toby fixed in demo branch
#2495 1340624905000000 amercader See #2467
#2494 1338994890000000 toby this was due to out of date version of demo branch - updated
#2493 1338986768000000 aron.carroll Editing ticket title (sorry Toby I know you hate it)
#2493 1342774354000000 toby @aron, I've removed the breadcrumb and got it to eat flash messages as these tend to be repeated at least for some actions - maybe the flash messages is overkill. Anyhow I think it's good enough for phase 3 and we should either say it is done or move to phase 3 I think this would benefit from some design from Sam at some point and I quite like a graphic on an error page to make it a little pretty but not any rush
#2491 1338979614000000 toby fixed by commit e6554e7
#2488 1339412538000000 johnglover Works for me on 1.7.1. Perhaps floapps was using older groups (of type 'group' instead of 'organization') and/or didn't add a user to the group?
#2487 1338892521000000 johnglover https://github.com/okfn/ckanext-ecportal/commit/958208cfec1dfddb792b9b0ce0ac835fb1e2872a
#2484 1340013145000000 toby merge requested https://github.com/okfn/ckan/pull/17
#2484 1340285964000000 toby merged into master
#2479 1338468431000000 markw An alternative (and better, but harder) way of dealing with the 'maintainer' issue would be to allow messages to be sent between CKAN accounts, and to have a field whose value is the maintainer's login.
#2477 1343124123000000 seanh See thread on ckan-dev for list of officially supported non-core extensions: http://lists.okfn.org/pipermail/ckan-dev/2012-June/002439.html
#2474 1338982780000000 aron.carroll Closing this as we've decided to go with Jinja. There's some basic docs here: https://github.com/okfn/ckan/blob/feature-2375-demo-theme/doc/templating.rst And a template overview: https://github.com/okfn/ckan/blob/feature-2375-demo-theme/doc/template-blocks.rst Generally it's worth looking at the Groups pages to see how they're built.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
Note: See TracReports for help on using and creating reports.