Ticket #1068 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

metadata_modified problem

Reported by: dread Owned by: dread
Priority: minor Milestone: ckan-v1.4-sprint-5
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none

Description

This test has been failing since the clocks changed:

======================================================================
FAIL: ckan.tests.models.test_package.TestPackageRevisions.test_02_metadata_created_and_modified
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dread/hgroot/pyenv-ckan2/lib/python2.6/site-packages/nose-0.11.3-py2.6.egg/nose/case.py", line 186, in runTest
    self.test(*self.arg)
  File "/home/dread/hgroot/ckan2/ckan/tests/models/test_package.py", line 283, in test_02_metadata_created_and_modified
    assert out == exp, (out, exp)
AssertionError: (datetime.datetime(2011, 4, 1, 10, 45, 50, 875509), datetime.datetime(2011, 4, 1, 9, 45, 50, 875509))

----------------------------------------------------------------------

Change History

comment:1 Changed 3 years ago by dread

  • Owner changed from rgrp to dread

comment:2 Changed 3 years ago by dread

  • Status changed from new to closed
  • Resolution set to fixed

The problem was the use of mktime which is localised. Also spotted a problem with the use of localised time stored in the datestamp created in migration script 29, when initialising the repo.

Fixed in a2094932e5e4 in release 1.3.3 branch.

Note: See TracTickets for help on using tickets.