Dataset delete button

[dread]

From Jonathan gray:

At the moment to delete a package you have to go to 'state' and change from 'active' to 'deleted'.

For me this was not very obvious, and someone recently wrote to me about this too.

Its a small issue - but unless you know what 'state: active' refers to, its not obvious what this means, nor that this is where to go if you want to delete a package.

From UI perspective this could be replaced by either a trash can or some text that says 'delete', perhaps with some prompt that explains what happens when you delete a package - explaining that non-admins won't be able to see it, and how you purge, etc.

[dread]

Cheers for taking this on Tom

[dread]

There is a package_delete logic function to achieve this (and indeed group_delete too).

One of the reasons we haven't advertised it with a button is that anyone with 'edit' privileges can go round deleting packages. It's one thing spotting graffiti, but when you delete packages, it takes a lot of effort to spot nefarious deletions.

I think should either restrict deleting to sysadmins or have a separate authz-action DELETE-PACKAGE that is not given to the average logged-in user.

I believe Wikipedia does something similar - the average Joe can edit, but can't delete pages.

[zephod]

Refactored it to be (a) easy to find, and (b) a two-stage process which has a little more gravity. Like Bitbucket and GitHub?.

​https://github.com/okfn/ckan/commit/f3a4c3de70da08d396da4e65a5d286b253be0e0b

[dread]

Went into CKAN 1.6