Ticket #2314 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

parse_rfc_2822 tests failing in some timezones

Reported by: seanh Owned by: icmurray
Priority: major Milestone: ckan-sprint-2012-05-15
Component: ckan Keywords: [0.5d]
Cc: Repository: ckan
Theme: none

Description

These two tests:

ckan.tests.lib.test_helpers.TestHelpers?.test_parse_rfc_2822_gmt_case

ckan.tests.lib.test_helpers.TestHelpers?.test_parse_rfc_2822_with_offset

have been failing in certain timezones. In the UK they pass, if you're in Germany they'll fail.

The function being tested uses datetime.datetime.fromtimestamp() which uses the local time, but the tests compare the results against hardcoded strings, so the tests cannot work in different timezones.

Change History

comment:1 Changed 2 years ago by seanh

  • Owner changed from seanh to icmurray
  • Status changed from new to assigned
  • Milestone changed from ckan-v1.7 to current-ckan-sprint-2012-05-15

comment:2 Changed 2 years ago by icmurray

  • Priority changed from awaiting triage to major

comment:3 Changed 2 years ago by icmurray

  • Keywords [0.5d] added

comment:4 Changed 2 years ago by icmurray

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.