Ticket #2701 (closed enhancement: fixed)
add comments to datasets
| Reported by: | shevski | Owned by: | toby |
|---|---|---|---|
| Priority: | major | Milestone: | demo phase 3 |
| Component: | ckan | Keywords: | demo-theme |
| Cc: | shevski | Repository: | ckan |
| Theme: | none |
Description
disqus??
Change History
comment:1 Changed 21 months ago by aron.carroll
- Cc shevski added
- Owner changed from aron.carroll to toby
- Status changed from new to assigned
- Milestone changed from demo phase 4 to demo phase 3
comment:2 Changed 21 months ago by aron.carroll
- Status changed from assigned to closed
- Resolution set to fixed
BTW moved this to phase three as I consider it done.
comment:3 Changed 21 months ago by toby
Would be good to decide on the "one" way to do this.
As the new extension guru/deity I say helper functions are the future - my word is the law
a) a missing helper just returns so they can be added to templates even when not implemented, a missing template gives a 500
b) helper functions hide the implementation which I think is a good thing
c) helpers are just soooooooo cool - plus they are new and shiny (what am I saying?)
As far as moving the phase I'm not too fussed we can be ahead on phase 4
Note: See
TracTickets for help on using
tickets.
I've updated the disqus extension (in development branch) and added the snippet to the development branch of the demo plugin.
Toby, not sure about the way the disqus plugin is implemented via a helper vs the spacial plugin using a snippet. Would be good to decide on the "one" way to do this.