Ticket #2722 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Ordering or search of datasets of a group brings up 'no results'

Reported by: shevski Owned by: aron.carroll
Priority: awaiting triage Milestone: demo phase 3
Component: ckan Keywords: demo-theme
Cc: aron.carroll Repository: ckan
Theme: none

Description

1. go to a group, e.g.  http://s031.okserver.org:2375/group/data-explorer 2. Order by anything, e.g. choose 'popular' and click go 3. "sorry no datasets found" message appears instead of ordering the group datasets in wanted order

 http://s031.okserver.org:2375/group/data-explorer?q=&sort=views_recent+desc

Change History

Changed 10 months ago by shevski

  • cc aron.carroll added
  • summary changed from Sorting/ ordering datasets of a group brings up 'no results' to Ordering or search of datasets of a group brings up 'no results'

In fact, this is the wrong bug. Search doesn't seem to work *at all* in groups

Tried to search  http://s031.okserver.org:2375/group/data-explorer?q=&sort=views_recent+desc

Bug 1: no results Bug 2: the text display covers the order by box

Changed 10 months ago by toby

  • milestone changed from demo phase 2 to demo phase 3

@ira

I have disabled the sort order of group datasets in phase 2 as it is totally broken - I'll re-add it in phase 3

Also the comment you made you added bug2 - text covers order by box -PLEASE DO NOT DO THIS - all it does is make the tickets really hard to deal with - if this becomes a habit I will close all such tickets as INVALID as it makes trac unusable for developers - THIS IS REALLY IMPORTANT - cheers

@aron,

can you watch for feature creep in tickets and let me know if it happens - thanks

Changed 10 months ago by shevski

Hey, I only mentioned bug 2 here because I'm pretty certain this already exists as a separate ticket. Have definitely reported it before, but i think someone else created the ticket - so just wanted to remind that this hasn't been fixed either yet.

What's the best way to do this in future?

Changed 10 months ago by toby

@ira,

It is much easier to work with tickets that only cover one thing - If something is found then the easiest thing is to add a new ticket. If you feel it's related to another ticket then you can add that to the new ticket eg related to #1234

If tickets need combining it is easy for us devs to do it. Basically adding something to a ticket is generally a bad thing. Sometimes it's fair enough if something is missing for a new feature being reviewed etc - but even then a new ticket is generally not a problem. Small tickets are nice to work on as we can close them quick etc. The old [super] style tickets have been banned as they generally lead to owners becoming demotivated and unproductive.

It's always nice if you can find if a ticket already exists but I don't mind you opening a few duplicates if you can't find the ticket - for the demo you can probably just skim the tickets in the milestones as there aren't too many - but as you know I try to review them quite often.

Also please don't reopen really old tickets just add a new one If it's been closed in the last month or so then feel free to re-open if you're sure it's not just waiting for release - you can always check with the last owner of the ticket.

hope that makes sense

Changed 10 months ago by toby

  • milestone changed from demo phase 4 to demo phase 3

Changed 10 months ago by toby

  • owner changed from toby to aron.carroll
  • status changed from new to assigned

@aron,

can you re-add the dropdown and sort the overlap issue not sure which template it's in

Changed 10 months ago by aron.carroll

  • status changed from assigned to closed
  • resolution set to fixed

Done in 8769233. I think the overlap issue was fixed for the dataset search a while ago. Let me know if it remains.

Note: See TracTickets for help on using tickets.