Custom Query (2152 matches)
Results (517 - 519 of 2152)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#955 | fixed | Tidy up tests | dread | dread |
Description |
|
|||
#2230 | fixed | Tidy up of search facets code duplication | seanh | |
Description |
Because of a clash between two development branches there is some duplication of code to do with code facets (note: at the time of writing the code duplication exists only on the feature-1821-multilingual-extension branch, but this will be merged into master at some point): The package_search() function is adding the search facets to the search results twice with two different data structures, with keys "facets" and "new_facets". It should be reduced to just the new facets (with the key changed to "facets"). Also the group and package controllers are adding both facets and new_facets to the context, should be new_facets only (but renamed to facets). The facet_items() function in helpers.py should be removed, it uses the old facets structure and shouldn't be needed anymore with the new facets structure. In facets.html, facet_sidebar() should be removed as it uses the old facets structure and facet_div() implements the same functionality but uses the new facets. In facets.html, facet_list_items() will have to be updated to not use the facet_items() helper and to use the new facets structure instead. Anywhere that "new_facets" appears it will have to be changed to "facets" (e.g. in the ckanext/multilingual/plugin.py. This is the merge commit that introduced the duplication: https://github.com/okfn/ckan/commit/1153aa876f54c22289e460aeececea22d1d4d51d This is the earlier commit where the search facets were refactored: https://github.com/okfn/ckan/commit/3970e52008b75933fda1be1d488bed2578d98c9c |
|||
#2707 | fixed | Tidy up additional info boxes on dataset and resource pages | toby | shevski |
Description |
This currently looks terrible. Some simple things we should do to improve this.
|