CKAN: Ticket Query

#2302: Simple theming

ross — Mon, 16 Apr 2012 13:23:48 GMT

Needs re-testing after the ODS re-theme. ====

Simple image upload, text changes and css updates for a single instance. All done on a single configuration/admin page

See http://ckan.okfnpad.org/simple-themes for user stories

[x] Initial version will only take an image_url rather than allowing an upload.

[x] New page with form for title, tagline, image loader etc.

[x] Allow the user to paste in values for the CSS, do we really want a colour swatch?

[x] Generate local CSS override which should *somehow* override colors in the original CSS.

[x] Allow user to provide text for an about page.

#2408: Only 4 'extras' can be added at a time

markw — Tue, 22 May 2012 10:47:19 GMT

The settings > extras page for a dataset allows extra fields to be added, but only four can be added a time in a single atomic update. It would be helpful to have an 'add another' button on the form that can be used any number of times.

#2458: Create demo statistics page

aron.carroll — Mon, 28 May 2012 13:31:46 GMT

Discussion:

https://okfn.basecamphq.com/projects/9558659-demo-ckan-front-end/posts/62998513/comments

Implementation:

http://s031.okserver.org:2375/en/stats

#2614: improve the documentation around less/node

toby — Wed, 27 Jun 2012 16:52:08 GMT

needs to move to a better home

better ubuntu install instructions plus test they work

apt-get install nodejs

integrate with paster

#2642: Adapt harvest frontend to new theme

amercader — Mon, 09 Jul 2012 15:03:16 GMT

#2652: get qa working with the demo

toby — Tue, 10 Jul 2012 16:21:55 GMT

#2680: review group deletion

shevski — Mon, 16 Jul 2012 11:02:05 GMT

Super admins & owners/creators of groups need a way to delete them

Is the auth model in place for all this stuff? May be worth sitting down and going through how this should work

Currently can change state from active to deleted - this is not ery user friendly (want a button with a 2 step process maybe?) & I'd like to know who can view this option? Everyone who can edit a group? Who can edit?

#2700: language box

shevski — Wed, 18 Jul 2012 14:03:43 GMT

lang box improvements: styling, images, submit upon selection

#2701: add comments to datasets

shevski — Wed, 18 Jul 2012 14:06:46 GMT

disqus??

#2707: Tidy up additional info boxes on dataset and resource pages

shevski — Wed, 18 Jul 2012 14:24:31 GMT

This currently looks terrible. Some simple things we should do to improve this.

Localise and captitalise known (non custom) keys into human titles. eg. "size", "created_at", "mime_type".
Apply units to values of known keys where possible eg. "size in appropiate units"
Convert dates into a more human friendly format. We can avoid localisation hell by using an ISO format like YYYY/MM/DD hh:mm:ss which is still better than ISO8061
Move the non user fields to the top of the table.

#2710: make the api_info.html not look like shit

toby — Wed, 18 Jul 2012 15:13:05 GMT

you know the score

#2713: button colour not set properly in variables.css

toby — Thu, 19 Jul 2012 14:00:28 GMT

to reproduce run

paster color fuchsia -c development.ini

then go to http://localhost:5000/dataset/new

Add button is blue gradient at the top this should be overridden in variables.less

when added send this ticket to me and i'll update the color command to change it

#2717: French breaks the demo header

toby — Fri, 20 Jul 2012 10:34:47 GMT

when language is french

a) the menu overlaps the logo

b) much of the logo becomes unclickable

@shevski

a) seems like you b) is aron

#2722: Ordering or search of datasets of a group brings up 'no results'

shevski — Sun, 22 Jul 2012 09:20:54 GMT

go to a group, e.g. http://s031.okserver.org:2375/group/data-explorer
Order by anything, e.g. choose 'popular' and click go
"sorry no datasets found" message appears instead of ordering the group datasets in wanted order

http://s031.okserver.org:2375/group/data-explorer?q=&sort=views_recent+desc

#2724: Inconsistent labelling / UX on draft datasets

shevski — Sun, 22 Jul 2012 09:30:02 GMT

One of the datasets here: http://s031.okserver.org:2375/en/user/shevski has [DRAFT] after it. It's not clear why this has been added -> user confusion
The draft dataset is not clickable in the dataset list
The ff dataset (same as the ff [DRAFT] dataset) in the Activity Steam section a) is clickable and b) does not have [DRAFT] after it

#2739: Help text for format field

shevski — Tue, 24 Jul 2012 09:46:15 GMT

Can we please add some text next to the format field when user adding a new resource along the lines of:

"This will be generated automatically, but you can edit if you wish"

It always seems to work better when the user does not fill it themselves...

#2750: javascript translations need ripping

toby — Wed, 25 Jul 2012 11:37:26 GMT

we need to ensure that translations in .js files are ripper for translation

look at what is available as preference to creating our own

#2755: user pages very slow to load

shevski — Wed, 25 Jul 2012 14:09:55 GMT

navigating to a user page -one's own or http://s031.okserver.org:2375/en/user/ira or http://s031.okserver.org:2375/en/user/shevski, even when signed out is noticeably slower than navigating between other parts of the site; over 2 seconds. Maybe even 3

#2759: resource upload pointer incorrect

toby — Thu, 26 Jul 2012 07:57:49 GMT

On the add resource forms new or existing dataset

when hovering over Upload a file css cursor should be pointer not text

#2760: fix spacing between data API button and other buttons on dataset page

shevski — Thu, 26 Jul 2012 10:09:20 GMT

see spacing between 'download' button and 'data api' button http://s031.okserver.org:2375/dataset/afterfibre/resource/66f5b980-06db-4ccd-a005-c18de4d68a4b

#2765: Demo login error messages

aron.carroll — Thu, 26 Jul 2012 15:50:42 GMT

I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.

So in general, provide an error dict

#2767: Upgrade macro form.select to use tuples instead of dicts

aron.carroll — Thu, 26 Jul 2012 16:14:58 GMT

This keeps the intended order.

#2769: add site wide related page

shevski — Thu, 26 Jul 2012 17:26:07 GMT

Can we add the related dashboard (http://trac.ckan.org/ticket/2347) to demo - central place to show off all the related stuff added.

#2774: Provide a method of passing localised strings into the JavaScript

aron.carroll — Mon, 30 Jul 2012 15:11:12 GMT

We need to be able to do the following:

Rip the localised strings from the JavaScript? source code. These are strings that look like _('String'), translate('String') and isPlural('String') .
An endpoint that provides the translations in the correct locale for the user.
The endpoint should provide the locale as JSON (possibly using http://jsgettext.berlios.de/doc/html/po2json.html or similar tool)

The JavaScript? can then read this file on page load.

#2776: add styled text field for header title

shevski — Tue, 31 Jul 2012 08:50:03 GMT

to use on demos instead of the ckan logo & tag line.

Design here: https://okfn.basecamphq.com/projects/9558659-demo-ckan-front-end/posts/63387712/comments#190457381 (First, text only one at the bottom)

#2778: apps dashboard needs some design love

toby — Tue, 31 Jul 2012 11:27:20 GMT

apps dashboard available at http://localhost:5000/apps in main dev branch

I have got this to work in the demo however

a) it is a bit ugly

b) the template could do with some sorting eg the dropdowns should be being created in a nicer way

#2779: add 'deleted' to deleted datasets that admins can view

shevski — Tue, 31 Jul 2012 12:17:57 GMT

Currently, as a logged in admin, you can view deleted datasets just as if they are live datasets. Nothing distinguishes them apart from normal datasets other than they don't show up on the dataset page

This is potentially very confusing Can we add some kind of banner / label to deleted datasets to show they have been deleted?

& Do you guys need Sam to design this?

Related ticket for undeleting datasets - http://trac.ckan.org/ticket/2780

#2781: add way to edit homepage text to simple theming

shevski — Tue, 31 Jul 2012 12:42:03 GMT

demo.ckan.org has a small field for adding text on homepage current text: "Welcome to the CKAN demo Try out standard CKAN functionality in a sandbox environment. Search for datasets directly from the homepage or by navigating to the Datasets search page where you can facet by tags, groups and format."

Want to make this editable for demos

#2789: logo fixups

toby — Wed, 01 Aug 2012 15:32:21 GMT

With the text logo I'd like the tag line to be under the site name so some css like

float:left;clear:left;font-size:13px;line-height:0.1;

Also the site name can be larger if no tagline

commit daac54dbd856 I've added a new global g.header_css that sets the hgroup class to

'header-image' 'header-text-logo' 'header-text-logo-tagline'

I think maybe we should also have 'header-image-css' for the equivalent of the class="logo" in the link to allow/stop the image replacement

#2791: Logo fix

toby — Thu, 02 Aug 2012 08:10:34 GMT

@aron

We should be able to have longish tag lines that look ok currently they wrap and stop the logo text being clickable

Can we have white-space:nowrap; for the tagline so long ones don't wrap and maybe look at aligning long ones

#2792: dropdown fixes - open correctly

toby — Thu, 02 Aug 2012 08:14:56 GMT

http://s031.okserver.org:2375/ language dropdown expands downwards it should open upwards

select2 can do this see http://ivaynberg.github.com/select2/#documentation can you see if we can get this in ckan demo

#2793: Markdown of resource page not rendered as markdown

ross — Thu, 02 Aug 2012 08:37:43 GMT

As per #2650 (on master/1.8 now)

If the resource has a description it isn't rendered as markdown ..

#2794: top buttons missing on edit resource

toby — Thu, 02 Aug 2012 08:58:46 GMT

http://s031.okserver.org:2375/dataset/resource-markdown/resource_edit/ba1b094d-697c-47c4-a72a-6c2557da5409

should have back to resource as a minimum

#2797: plain_textarea styling

toby — Fri, 03 Aug 2012 13:27:02 GMT

http://localhost:5000/ckan-admin/config uses a plain (non markup) textarea for custom css

I've added form macro plain_textarea to provide one, however it renders without a bottom border due to markup textarea styling can you fix this - thanks

#2799: Translations for demo not picking up {% trans %} blocks

aron.carroll — Mon, 06 Aug 2012 08:50:05 GMT

Also they seem to be missing the odd _() block. Such in the new package form.

https://github.com/okfn/ckan/blob/2375-demo-theme-development/ckan/templates/package/snippets/package_form.html#L44

#2801: no way to see full description of a related item

shevski — Mon, 06 Aug 2012 09:36:49 GMT

e.g. see here: http://s031.okserver.org:2375/apps same with related page on a dataset

#2802: Need to tweak the JSON formatting of the localisations

aron.carroll — Mon, 06 Aug 2012 10:27:27 GMT

This is what we need the JSON to look like. Taken from the Jed documentation (http://slexaxton.github.com/Jed/).

{
      // The empty string key is used as the configuration
      // block for each domain
      "" : {
        // Domain name
        "domain" : "the_domain",
        // Language code
        "lang" : "en",
        // Plural form function for language
        "plural_forms" : "nplurals=2; plural=(n != 1);"
      },
      // Other keys in a domain contain arrays as values
      // that map to the translations for that key.
      // Gettext suggests that you use english as your keys
      // in case the key isn't found, and it can just pass
      // the value directly through.
      // Note: by convention, the 0-index location of the translations
      // is never accessed. It's just a thing, I guess.
      "a key" : [ null, "the translation", "the plural translations", ... ],
      // The plural form string is converted into a function
      // and the value that's passed into the gettext call
      // is passed into the plural form function. It's result
      // (plus 1) is the index that the translation comes from.
      // We're using sprintf interpolation on our keys so we can
      // then sub in the _actual_ values into the result.
      "%d key" : [ null, "%d key", "%d keys" ],
      // Contexts are keys that are just prefixed with a context string
      // with a unicode \u0004 as the delimiter.
      // You can use it for anything. Usually it's just for being content aware
      // in some way (e.g. male vs. female, product vs. category)
      "context\u0004%d key": [ null, "context %d key", "context %d keys" ]
    }

This looks like an appropriate python library to do the formatting. http://pypi.python.org/pypi/pojson/ but I'll leave to your discretion.

Finally an API endpoint that returns the appropriate request would save us making requests to the i18n directory.

/api/i18n/{locale}

For example if the current url is http://localhost:5000/pl/dataset then the client would request:

http://localhost:5000/api/i18n/pl

This should return the Content-Type: application/json and a 200 with an appropriate JSON body (this can be the language requested or an appropriate fallback). I think that if the fallback is the default language (in most cases English) then we just return a 204 No Content to save data.

#2803: Convert all JS translations to use keywords

aron.carroll — Mon, 06 Aug 2012 11:16:57 GMT

#2804: please make download button blue

shevski — Mon, 06 Aug 2012 11:24:15 GMT

on resource pages (e.g. http://s031.okserver.org:2375/dataset/afghanistan-election-data/resource/f6331f99-51f6-44d9-95b9-b20f3b74f360), same as old ckan for continuity and to highlight!

#2807: autocomplete.js error

toby — Mon, 06 Aug 2012 15:17:08 GMT

@aron,

edit dataset has a js error

http://localhost:5000/dataset/edit/1-kmwaterfractionfromnationaltopographicdatabasemapscanada

TypeError?: options is undefined [Break On This Error]

this.lookup(options.term, options.callback);

autocomplete.js (line 231)

#2808: Confirm delete dialog badly placed on small screen

toby — Tue, 07 Aug 2012 09:57:54 GMT

If you make your browser window short - say half screen height on a page with delete eg http://localhost:5000/dataset/edit/1-kmwaterfractionfromnationaltopographicdatabasemapscanada

the dialog box is partially off the screen - it should try to stay on screen

#2809: _ not defined for modules

toby — Tue, 07 Aug 2012 10:37:43 GMT

eg on confirm delete

http://localhost:5000/zh_TW/dataset/edit/1-kmwaterfractionfromnationaltopographicdatabasemapscanada

_(....) gives [object Object] not translation

#2826: Null group image

danieljohnlewis — Thu, 09 Aug 2012 09:45:46 GMT

Problem: Example group ( http://s031.okserver.org:2375/en/group/example-group ) has a broken image, image not found. Link either incorrect, or no image set, if no image set then shouldn't it show a default image? Expected: There should be an image.

#2836: Need extra info for forms

toby — Fri, 10 Aug 2012 13:38:51 GMT

like we have on the form here

http://s031.okserver.org:2375/harvest/new

you said it partly exists so maybe I just need some training

#2837: checkbox styling

toby — Fri, 10 Aug 2012 13:39:53 GMT

Is this done I know checkboxes are a pain but it looks a bit out of place compared to the other items.

#2840: tag line styling

toby — Mon, 13 Aug 2012 09:48:27 GMT

@aron

Is it possible to get the tagline text to float the other way

at the moment we have

...........Title Tag line to here

I'd like

...........Title ...........Tag line to here

is this possible or too much pain

based partly on this comment Markw wrote

A minor problem visible on the home page <http://s031.okserver.org:2375/> and other pages, when viewing in both Chrome and Firefox:

if the browser width is not very wide, the tag line 'Open source data portal' vanishes off the *left* hand side of the screen. For some reason the browser doesn't even recognise this with a horizontal scroll bar (as it does when stuff is off the *right* hand side) - it just chops off the text.

#2841: Slug generation fails on demo dev

amercader — Mon, 13 Aug 2012 11:00:53 GMT

On the add dataset form, slug generation fails with JS error:

Uncaught TypeError: Object [object Object] has no method 'incompleteFormWarning'    basic-form.js:5

#2847: 'show inactive sources' checkbox displaying incorrectly

shevski — Mon, 13 Aug 2012 13:25:22 GMT

On harvest page: http://s031.okserver.org:2375/harvest the checkbox appears above the text and not clear what it refers to/

Beter to relocate to the left (as on publicdata.eu) see screenshots attached.

#2848: no dataset descriptions on front page

shevski — Tue, 14 Aug 2012 10:01:45 GMT

http://s031.okserver.org:2375/

#2852: better message for trying to refresh inactive sources in harvest

shevski — Wed, 15 Aug 2012 16:31:57 GMT

Currently if you try to refresh (i.e. schedule the harvester to re-run) an inactive source (one who's state is 'withdrawn' - e.g. http://s031.okserver.org:2375/harvest/3feea629-32d8-4431-9957-9f31d32864f1)

you get the error message: "An error occurred: [Can not create jobs on inactive sources]"

This could be better and not red, e.g. and info box (maybe yellow) saying that "Cannot re-run harvesting on inactive sources. Please first change the status to 'active'"

#2853: unclear error message in refreshing harvest source

shevski — Wed, 15 Aug 2012 16:34:42 GMT

Tried to refresh the datagm harvest source to get error message:

"An error occurred: [There already is an unrun job for this source]"

This is unclear and not sure why it created an error. We should have something informative such as "A harvest has already been scheduled for this source"

Do we have a date/time for when this has been scheduled that we can display?

#2855: language box no longer functional

shevski — Wed, 15 Aug 2012 16:45:52 GMT

e.g. tried changing the lang here: http://s031.okserver.org:2375/ to no effect. Doesn't work on any other pages either. Flags have also dissappeared

#2856: server error when clicking on deleted app link

shevski — Wed, 15 Aug 2012 16:54:44 GMT

go to http://s031.okserver.org:2375/user/okfn
Click on activity stream
Click on 'Deletion test' related item that's linked to in entries 1 & 2
Server error

#2858: Harvester tweaks

toby — Thu, 16 Aug 2012 07:46:38 GMT

I've had a look at the new harvesting theme, it looks great, thanks. I did some minor changes and reworded the errors as per tickets #2852 and #2853, but I kept the messages red, as the only other ones available ("flash_notice") are blue and are not very prominent.

Toby, on the old form there was a list of descriptions for all available harvesters which could be nice to have back. I couldn't find an easy way with the new form macro, so I don't know how easy would be to implement

http://i.imgur.com/pzS8z.png

#2860: target blank link in qa report

shevski — Thu, 16 Aug 2012 10:43:46 GMT

can we get the link going to an explanation of the 5 star system on page http://s031.okserver.org:2375/qa/dataset/five_stars to open in new tab? it's leaving demo all together so better to open in new tab than navigate away

#2871: user profile about text does not show up

shevski — Thu, 16 Aug 2012 11:02:33 GMT

tested with my http://s031.okserver.org:2375/user/shevski and daniel's account. I have added about text and yet see ' Irina Bolychevsky

You have not provided a biography.'

The about text is saved (and viewable on the edit form itself) but does not show on profile

#2812: Groups description needs improving

markw — Wed, 08 Aug 2012 09:59:13 GMT

The 'What are Groups?' text at <http://demo.ckan.org/group> is a bit naff. Here is a suggested replacement:

What are groups?

Groups allow you to group users and data together so that they are easier to manage. For example datasets in a group could be visible only to group members, or publicly visible but only editable by group members.

Groups can be used to collect together datasets from a single publisher, or related to a particular project, for example.

#2782: integrate with leaflet for demo background generation

shevski — Tue, 31 Jul 2012 15:34:17 GMT

use http://leaflet.cloudmade.com/ properly to generate map backgrounds for demo instances