CKAN: Ticket #1050: refactoring of ckan/lib/authztool.py

status changed; owner set

johnlawrenceaspden — Fri, 18 Mar 2011 12:39:21 GMT

owner set to johnlawrenceaspden
status changed from new to assigned

johnlawrenceaspden — Fri, 18 Mar 2011 12:43:20 GMT

there's already a file ckan/tests/test_authz.py, which looks like the appropriate place for new tests.

type changed; keywords set

johnlawrenceaspden — Fri, 18 Mar 2011 12:53:23 GMT

keywords refactoring auth added
type changed from defect to enhancement

dread — Fri, 18 Mar 2011 14:27:34 GMT

I may misunderstand how you intend to build the WUI Admin interface, but I think most of the stuff in authztool is just marshalling command line parameters anyway. The bits which do anything are factored out.

For example, to list rights you just loop over obj_classes to call model.Session.query(obj_class).all() and then display the values: type(subj).__name__, subj.name, role, type(obj).__name__, obj.name.

To change a right you simply call model.add_user_to_role(subj, role, obj) or model.add_authorization_group_to_role(subj, role, obj).

But of course if there is useful stuff to factor out then be my guest!

description changed

johnlawrenceaspden — Fri, 18 Mar 2011 14:42:28 GMT

description modified (diff)

description changed

johnlawrenceaspden — Fri, 18 Mar 2011 15:10:13 GMT

description modified (diff)

priority, description changed; milestone set

rgrp — Fri, 08 Apr 2011 16:22:11 GMT

priority changed from awaiting triage to major
description modified (diff)
milestone set to ckan-v1.4

summary changed

rgrp — Fri, 08 Apr 2011 16:22:42 GMT

summary changed from refactoring of ckan/lib/authztool.py to Authz lib improvement and refactor of ckan/lib/authztool.py

milestone changed

thejimmyg — Mon, 18 Apr 2011 09:16:28 GMT

milestone changed from ckan-v1.4 to ckan-v1.4-sprint-6

This should also feed into #1075 which will be being worked on this week.

owner, milestone changed

thejimmyg — Fri, 08 Jul 2011 11:47:24 GMT

owner changed from johnlawrenceaspden to thejimmyg
milestone changed from ckan-v1.5 to ckan-backlog

milestone deleted

thejimmyg — Wed, 20 Jul 2011 16:24:34 GMT

milestone ckan-backlog deleted

status changed; resolution set

dread — Wed, 07 Sep 2011 11:15:17 GMT

status changed from assigned to closed
resolution set to invalid

There's been no objections to my comment 6 months ago saying this is invalid, so marking it invalid. Feel free to reopen if there is indeed a case here.