http://localhost/ticket/1077 <h2 id="Option1:ChangesetModel">Option 1: 'Changeset' Model</h2> <p> See <a class="assigned ticket" href="http://localhost/ticket/1135" title="enhancement: Changeset model for vdm (assigned)">ticket:1135</a> for vdm ticket. This would involve a) moving to changeset in vdm b) doing the migration in ckan to support this. </p> <p> Have developed a new "changeset" based model for revisioning in vdm. </p> <h3 id="Implementation">Implementation</h3> <ul><li>The main challenge with this change is schema and data migration </li></ul><p> Every revisioned object has a revision_id and revision attribute. </p> <p> Approximate algorithm: </p> <pre class="wiki">Revision -&gt; Changeset for revtype in [PackageRevision, ...]: for pkgrev in package_revision: changeset = lookupchangeset(package_revision) ChangeObject(cset, (table, id), dictize(pkgrev)) </pre><p> Question: </p> <ul><li>does pkg include tags attributes or not? or we have to dictize, pkgrev, pkg2tagrev, and tag. Probably the latter. </li></ul><h2 id="Option2:SimplifyRevisionObjectModel">Option 2: Simplify Revision Object Model</h2> <p> Just use a simpler vdm, see <a class="assigned ticket" href="http://localhost/ticket/1136" title="enhancement: Move to SessionExtension in vdm (assigned)">ticket:1136</a> (move to SessionExtension) and <a class="assigned ticket" href="http://localhost/ticket/1137" title="enhancement: Remove need for statefulness in vdm (assigned)">ticket:1137</a> (remove need for statefulness in vdm). </p> <h2 id="Discussion">Discussion</h2> <p> Advantage of Option 1 versus 2: </p> <ul><li>Easier support for pending state and similar behaviour </li><li>No need to introduce new tables (and hence migrations) when making something revisioned (or not). </li></ul><h3 id="Disadvantages">Disadvantages</h3> <ul><li>Migration is required </li><li>More difficult to query revision history. <ul><li>Could be addressed by having ChangeObject have separate cols for table name and id but would likely be more difficult. </li></ul></li><li>Performance (?) <ul><li>Have one big ChangeObject table to query when looking at changed objects rather than many revision tables. <ul><li>Not sure this is a biggie as even with Revision model biggest revision object tables are probably on the order of the ChangeObject table </li></ul></li></ul></li></ul><h2 id="Conclusion">Conclusion</h2> <p> Implement Option 2 and leave Option 1 for present. </p> <p> Option 1 includes Option 2 so it seems that that is required in either case (so we may as well with Option 2). </p> <p> Option 1 requires significant effort (esp migration) so leave for present and then review the situation at some later date. </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/1077 Trac 0.12.3 rgrp Mon, 18 Apr 2011 11:36:41 GMT http://localhost/ticket/1077#comment:1 http://localhost/ticket/1077#comment:1 <ul> <li><strong>priority</strong> changed from <em>awaiting triage</em> to <em>critical</em> </li> <li><strong>description</strong> modified (<a href="/ticket/1077?action=diff&amp;version=1">diff</a>) </li> </ul> Ticket kindly Mon, 02 May 2011 11:01:19 GMT http://localhost/ticket/1077#comment:2 http://localhost/ticket/1077#comment:2 <ul> <li><strong>description</strong> modified (<a href="/ticket/1077?action=diff&amp;version=2">diff</a>) </li> </ul> Ticket rgrp Sun, 08 May 2011 12:24:53 GMT http://localhost/ticket/1077#comment:3 http://localhost/ticket/1077#comment:3 <ul> <li><strong>state</strong> set to <em>draft</em> </li> <li><strong>description</strong> modified (<a href="/ticket/1077?action=diff&amp;version=3">diff</a>) </li> </ul> Ticket kindly Sun, 08 May 2011 18:58:07 GMT http://localhost/ticket/1077#comment:4 http://localhost/ticket/1077#comment:4 <ul> <li><strong>description</strong> modified (<a href="/ticket/1077?action=diff&amp;version=4">diff</a>) </li> </ul> Ticket rgrp Thu, 12 May 2011 14:57:51 GMT http://localhost/ticket/1077#comment:5 http://localhost/ticket/1077#comment:5 <ul> <li><strong>description</strong> modified (<a href="/ticket/1077?action=diff&amp;version=5">diff</a>) </li> <li><strong>summary</strong> changed from <em>Switch to new vdm changeset model</em> to <em>Move to simpler vdm system</em> </li> </ul> Ticket shevski Fri, 08 Jul 2011 11:56:54 GMT http://localhost/ticket/1077#comment:6 http://localhost/ticket/1077#comment:6 <ul> <li><strong>milestone</strong> <em>ckan-v1.5</em> deleted </li> </ul> Ticket dread Fri, 28 Oct 2011 10:21:24 GMT http://localhost/ticket/1077#comment:7 http://localhost/ticket/1077#comment:7 <ul> <li><strong>priority</strong> changed from <em>critical</em> to <em>awaiting triage</em> </li> </ul> <p> I guess this is not a priority now. </p> Ticket kindly Mon, 18 Jun 2012 15:45:45 GMT http://localhost/ticket/1077#comment:8 http://localhost/ticket/1077#comment:8 <ul> <li><strong>milestone</strong> set to <em>ckan-backlog</em> </li> </ul> Ticket