http://localhost/ticket/1172 <p> The current codebase has one or two try: except; blocks that don't catch specific exceptions. Under no circumstances should any broad try: except: blocks be allowed unless the exceptions they catch are immediately re-raised. Uncaught exceptions are wasting us quite a lot of time when trying to track down problems. </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/1172 Trac 0.12.3 thejimmyg Fri, 08 Jul 2011 13:47:59 GMT http://localhost/ticket/1172#comment:1 http://localhost/ticket/1172#comment:1 <ul> <li><strong>milestone</strong> <em>ckan-v1.5</em> deleted </li> </ul> Ticket dread Wed, 10 Aug 2011 15:48:52 GMT http://localhost/ticket/1172#comment:2 http://localhost/ticket/1172#comment:2 <ul> <li><strong>owner</strong> changed from <em>thejimmyg</em> to <em>dread</em> </li> <li><strong>status</strong> changed from <em>new</em> to <em>assigned</em> </li> </ul> <p> I've started this on branch defect-1172-exceptions </p> Ticket dread Tue, 23 Aug 2011 16:51:21 GMT http://localhost/ticket/1172#comment:3 http://localhost/ticket/1172#comment:3 <ul> <li><strong>status</strong> changed from <em>assigned</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> <li><strong>milestone</strong> set to <em>ckan-current-sprint</em> </li> </ul> <p> Is in cset:47225f03e2af and merged to default for 1.4.4. </p> <p> It now barfs instead of failing silently: </p> <ul><li>if the ckan config file has any errors </li><li>search indexing error </li></ul><p> There are some other "except Exception" statements </p> Ticket dread Tue, 23 Aug 2011 17:01:23 GMT http://localhost/ticket/1172#comment:4 http://localhost/ticket/1172#comment:4 <p> I took out "raise" by mistake in ckan/lib/search/worker.py:26 but John has added it in in the corresponding place in ckan/lib/search/<span class="underline">init</span>.py on branch feature-1275-solr-search anyway. </p> Ticket