http://localhost/ticket/1350 <p> New js code running produced in the work following <a class="closed ticket" href="http://localhost/ticket/1294" title="enhancement: [super] Package creation and editing UX improvements (closed: fixed)">#1294</a> contains various string literals, and needs proper internationalisation. </p> <p> See files: </p> <ul><li>application.js </li><li>templates.js </li></ul><p> Furthermore, efforts can be made to tidy up strings as described in <a class="closed ticket" href="http://localhost/ticket/1329" title="defect: i18n poor in some templates - missing i18n tags (closed: fixed)">#1329</a>. </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/1350 Trac 0.12.3 zephod Wed, 21 Sep 2011 13:17:28 GMT http://localhost/ticket/1350#comment:1 http://localhost/ticket/1350#comment:1 <ul> <li><strong>description</strong> modified (<a href="/ticket/1350?action=diff&amp;version=1">diff</a>) </li> </ul> Ticket zephod Wed, 21 Sep 2011 16:58:08 GMT http://localhost/ticket/1350#comment:2 http://localhost/ticket/1350#comment:2 <ul> <li><strong>status</strong> changed from <em>new</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> <p> Was going to reimplement an old workaround described by Friedrich, where a language.js file is served through the home controller (with appropriate settings in routing.py) and so ${_('string literals')} will be translated. See: </p> <ul><li><a class="ext-link" href="https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/controllers/home.py#cl-48"><span class="icon">​</span>https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/controllers/home.py#cl-48</a> </li><li><a class="ext-link" href="https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/templates/home/language.js"><span class="icon">​</span>https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/templates/home/language.js</a> </li></ul><p> However the string-extraction mechanism seems geared towards Genshi templates and hacks are required to make it read a javascript file neatly (ie. without putting the *entire file* into a string for translation). A more elegant solution seems to be using an xi:include to pull in a genshi template which contains an html &lt;script&gt; tag. </p> <ul><li>cset:d5bf4c7ba293 </li></ul><p> Issue is resolved; strings are now translated. </p> Ticket zephod Mon, 03 Oct 2011 13:54:16 GMT http://localhost/ticket/1350#comment:3 http://localhost/ticket/1350#comment:3 <ul> <li><strong>milestone</strong> changed from <em>ckan-current-sprint</em> to <em>ckan-sprint-2011-09-26</em> </li> </ul> Ticket