CKAN: Ticket #1401: Some links don't take account when CKAN is mounted at a non-root URL

milestone changed

rgrp — Tue, 01 Nov 2011 10:12:39 GMT

milestone changed from ckan-v1.5 to ckan-v1.6

Hi, this is very useful to hear. Can you point out links or even better submit a patch / pull request: http://wiki.ckan.org/Submitting_a_code_patch

dread — Fri, 11 Nov 2011 18:56:45 GMT

Another problem is 401 redirect when your not authorized to do something, like creating a group. The redirect URL is set in the who.ini:

login_form_url= /user/login

cc set

dread — Wed, 23 Nov 2011 16:41:14 GMT

cc augusto.herrmann@… added

Patch from Augusto Herrmann for the icon URLs: http://pastebin.com/aRBQmftL

dread — Fri, 13 Jan 2012 13:23:13 GMT

When javascript calls other scripts, it misses the mount-point prefix. e.g. application.js has hard-coded URL /api/2/util/is_slug_valid

The URL prefix is stored in request.environSCRIPT_NAME? so perhaps this value should be put in the HTML somewhere for the javascript to get at?

summary changed

dread — Mon, 16 Jan 2012 18:30:36 GMT

summary changed from some links lack the site_url prefix to Some links don't take account when CKAN is mounted at a non-root URL

owner, status changed; keywords set

dread — Mon, 16 Jan 2012 20:51:51 GMT

keywords ux added
owner changed from flofokus to zephod
status changed from new to assigned

Links have been fixed on branch defect-1401-mount-non-root. (Instead of using c.site_url the links now just detect the mount url like the rest of the links.)

Now it needs the js and css to be fixed too. Reassigning to Tom for this.

Brazilians currently waiting for this to be fixed.

owner, milestone changed

rgrp — Fri, 20 Jan 2012 18:49:03 GMT

owner changed from zephod to rgrp
milestone changed from ckan-v1.6 to current-ckan-sprint-2012-01-23

status changed; resolution set

rgrp — Fri, 20 Jan 2012 20:05:04 GMT

status changed from assigned to closed
resolution set to fixed

Fixed. See https://github.com/okfn/ckan/commit/7088b1fcae685e56a280ec7b396b0f9803a477d9

@dread: not at all clear why we had to change from g.site_url to h.url_for (idea was people could set site_url if the site was not at root ...)

status changed; resolution deleted

dread — Fri, 27 Jan 2012 11:56:39 GMT

status changed from closed to reopened
resolution fixed deleted

Basic check of the home page shows the CSS has not been fixed:

GET http://127.0.1.1/img/find.png 404 (Not Found)
GET http://127.0.1.1/img/share.png 404 (Not Found)
GET http://127.0.1.1/img/collaborate.png 404 (Not Found)

status changed; resolution set

rgrp — Tue, 31 Jan 2012 09:10:14 GMT

status changed from reopened to closed
resolution set to fixed

Thanks for that dread. Have now fixed these issues as well: https://github.com/okfn/ckan/commit/abb99cae9972d45f4b3acfbf8ea711da398d8a4a

Re-closing.