CKAN: Ticket #1453: Flexible tag names

description changed

icmurray — Tue, 08 Nov 2011 17:43:12 GMT

description modified (diff)

description changed

icmurray — Thu, 10 Nov 2011 17:49:46 GMT

description modified (diff)

icmurray — Thu, 10 Nov 2011 17:59:15 GMT

Added the restriction of not allowing the double quote character, '"', as well as commas as this simplifies any use of quoting multiple words to mean a single tag name.

For example, this simplifies the use of quotes in identifying tags in internal markdown links:

tag:"multiple word tag name"

A possible solution is to allowing escaping, such as:

tag:"something about \"Ian\""

But I think the compromise is a better solution than allowing the escaping as it's simpler, and this may crop up elsewhere.

status changed

icmurray — Thu, 17 Nov 2011 16:47:32 GMT

status changed from new to accepted

The allowable characters in a tagname has changed to "unicode alphanmeric plus simple punctuation". This means:

alphanumeric (inc. foreign characters)
[ .-_]

The completed feature is in the feature-1453-flexible-tag-names branch.

Awaiting a code review.

description changed

icmurray — Fri, 18 Nov 2011 16:42:09 GMT

description modified (diff)

dread — Fri, 18 Nov 2011 16:52:58 GMT

Code review:

basically - really excellent code and very thorough :-)
links should have %20 rather than spaces (tests/misc/test_format_text.py:61)
also check unicode chars encoding in urls (tests/misc/test_format_text.py:115)
also check searching for the tag with this encoding (ckan/tests/functional/api/model/test_tag.py:35)
we follow the PEP8 coding style which I interpret to mean not having blank lines after a function definition. But whichever, we're not consistent from file to file, but we should be within each file. e.g. ckan/tests/forms/test_package.py:12.
moo package problem - need to ensure test works on its own and when run as part of the suite, so independent of whether moo exists. tests/functional/api/test_action.py:
best to make tag search case insensitive - see ckan/tests/functional/api/model
It's worth keeping the old test in addition to your modified one - because query for just {q:} will return both packages too. ckan/tests/functional/api/test_package_search.py:203
Let's add an example of tag search with quotes in /doc/api.rst:337
Please put imports at the top of the file, unless there's a good reason ckan/tests/functional/api/test_package_search.py:296
Can you not the old test any more? It seems sufficiently to the test you changed it to, so can we include both? ckan/tests/functional/api/test_package_search.py:295

milestone changed

icmurray — Mon, 21 Nov 2011 10:47:08 GMT

milestone changed from current-ckan-sprint-2011-11-21 to ckan-sprint-2011-12-05

icmurray — Tue, 22 Nov 2011 12:40:13 GMT

Updated code now in feature-1453-flexible-tag-names branch.

(Also, deleted the ian-review branch.)

status changed; resolution set

dread — Tue, 29 Nov 2011 15:50:30 GMT

status changed from accepted to closed
resolution set to fixed

I believe this is finished now. This was merged into master in cset:c0aaa31c4b7ded54d and headed for release 1.5.2.

dread — Thu, 16 Feb 2012 12:34:57 GMT

This has gone into release 1.6.