http://localhost/ticket/1740 <p> It's really bad to do <tt>from module import *</tt> and CKAN has a lot of them. I suggest a three-pronged approach: </p> <ol><li>Don't add any more of them. </li></ol><ol start="2"><li>When you're programming if you see an easy opportunity to remove one then do so. </li></ol><ol start="3"><li>At some point we should task someone to go through the code and remove them all (which is what this ticket is for), but this will be a big job and may break things. </li></ol><p> We should also get rid of most or all of the <tt>from module import foo</tt> and <tt>from module import foo, bar</tt> statements. </p> <p> I think the right thing to do is just <tt>import module</tt> and then use <tt>module.foo</tt> in your code. But if you find yourself doing <tt>module.foo.bar</tt> then you may have a code smell. </p> <p> See: <a class="ext-link" href="http://docs.python.org/dev/howto/doanddont.html"><span class="icon">​</span>http://docs.python.org/dev/howto/doanddont.html</a> </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/1740 Trac 0.12.3 dread Wed, 01 Feb 2012 11:14:44 GMT http://localhost/ticket/1740#comment:1 http://localhost/ticket/1740#comment:1 <p> I agree with getting rid of <tt>from module import *</tt> and the approach suggested. </p> <p> However, I really disagree with getting rid of <tt>from x import y</tt>. In particular we have a strong convention of using this for ckan.model. It is a valuable abbreviation as it is used so much in the logic layer and tests. If someone should accidentally reassign the value of model to something else then I believe it is simple to see what has gone wrong. </p> Ticket