http://localhost/ticket/2230 <p> Because of a clash between two development branches there is some duplication of code to do with code facets (note: at the time of writing the code duplication exists only on the feature-1821-multilingual-extension branch, but this will be merged into master at some point): </p> <p> The package_search() function is adding the search facets to the search results twice with two different data structures, with keys "facets" and "new_facets". It should be reduced to just the new facets (with the key changed to "facets"). </p> <p> Also the group and package controllers are adding both facets and new_facets to the context, should be new_facets only (but renamed to facets). </p> <p> The facet_items() function in helpers.py should be removed, it uses the old facets structure and shouldn't be needed anymore with the new facets structure. </p> <p> In facets.html, facet_sidebar() should be removed as it uses the old facets structure and facet_div() implements the same functionality but uses the new facets. </p> <p> In facets.html, facet_list_items() will have to be updated to not use the facet_items() helper and to use the new facets structure instead. </p> <p> Anywhere that "new_facets" appears it will have to be changed to "facets" (e.g. in the ckanext/multilingual/plugin.py. </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/2230 Trac 0.12.3 seanh Wed, 14 Mar 2012 16:55:39 GMT http://localhost/ticket/2230#comment:1 http://localhost/ticket/2230#comment:1 <ul> <li><strong>type</strong> changed from <em>enhancement</em> to <em>refactor</em> </li> <li><strong>description</strong> modified (<a href="/ticket/2230?action=diff&amp;version=1">diff</a>) </li> </ul> Ticket seanh Wed, 14 Mar 2012 17:02:40 GMT http://localhost/ticket/2230#comment:2 http://localhost/ticket/2230#comment:2 <ul> <li><strong>description</strong> modified (<a href="/ticket/2230?action=diff&amp;version=2">diff</a>) </li> </ul> Ticket icmurray Mon, 28 May 2012 11:31:47 GMT http://localhost/ticket/2230#comment:3 http://localhost/ticket/2230#comment:3 <ul> <li><strong>status</strong> changed from <em>new</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> Ticket