CKAN: Ticket #2438: resource_search action not accessible via GET request

milestone changed

icmurray — Mon, 28 May 2012 09:34:15 GMT

milestone changed from ckan-v1.8 to current-ckan-sprint-2012-06-25

keywords, status changed; owner set

icmurray — Mon, 28 May 2012 13:37:14 GMT

keywords [1d] added; [?d] removed
owner set to icmurray
status changed from new to assigned

Proposed solution:

Add a new q field which can be specified multiple times. Each q parameter is a string: {field}:term. : characters are escaped in the {field} by \:.

Mark the fields parameters as deprecated.

milestone changed

icmurray — Tue, 19 Jun 2012 09:26:13 GMT

milestone changed from current-ckan-sprint-2012-06-25 to ckan-v1.8

status changed

icmurray — Mon, 25 Jun 2012 14:53:32 GMT

status changed from assigned to accepted

priority changed

icmurray — Tue, 26 Jun 2012 18:41:52 GMT

priority changed from minor to awaiting merge

Ready to be merged [1]

Brief synopsis of changes:

altered return type of the action: from Resource domain objects to dictized resources. This is required if this action is to be made accessible through the action api as the domain object is not json-serializable. The 'old' return type is still available by passing in a flag in the context. In fact, this is required as the search layer uses this action, and deals with the domain objects directly.

decided that escaping the ':' (as described in above comments) wasn't necessary as resource fields shouldn't have ':' characters in them anyway.

improved action's docstring

'fields' parameter has been deprecated ( see #2603 ). Use of it by the search layer has been removed in favour of the new 'query' parameter. But it still works, and correctly maintains backward compatibility.

[1] https://github.com/okfn/ckan/pull/37

status changed; resolution set

amercader — Wed, 04 Jul 2012 12:46:45 GMT

status changed from accepted to closed
resolution set to fixed