CKAN: Ticket #2454: Create demo login page

milestone changed

aron.carroll — Mon, 28 May 2012 14:16:25 GMT

milestone changed from ckan-sprint-2012-05-29 to current-ckan-sprint-2012-06-25

owner, status changed

aron.carroll — Wed, 06 Jun 2012 14:36:15 GMT

owner changed from aron.carroll to toby
status changed from new to assigned

Implemented the templates for this. There are currently no decent error messages for missing fields, would be nice if we could have more specific error messages. eg. invalid username, username required, password required etc.

toby — Wed, 06 Jun 2012 14:55:36 GMT

I am against providing much more that you did something bad

things like invalid username leak info - people should not know if usernames exist.

Maybe I'm a bit mean about this.

I'd be happier to add some javascript check on the form post that checks for no password etc - maybe that's not so practical

owner changed

toby — Mon, 11 Jun 2012 16:18:07 GMT

owner changed from toby to aron.carroll

@aron,

I'd like to close this as a won't fix - your thoughts

owner changed

aron.carroll — Tue, 12 Jun 2012 09:35:27 GMT

owner changed from aron.carroll to toby

Hmm, I totally agree with you on the missing username front but it would be nice at least to provide the errors in the same way we do the other forms. Currently it just displays a flash message which is unexpected.

I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.

toby — Tue, 12 Jun 2012 09:56:40 GMT

@aron,

I'm going to leave this open for the moment but not make the requested change as I need to think of the best way forward. The flash message error is quite hard coded into the logic and I need to think of a nice solution.

priority changed

toby — Wed, 13 Jun 2012 10:00:56 GMT

priority changed from major to minor

milestone changed

toby — Tue, 19 Jun 2012 09:54:44 GMT

milestone changed from current-ckan-sprint-2012-06-25 to demo phase 1

milestone changed

toby — Tue, 26 Jun 2012 11:34:02 GMT

milestone changed from demo phase 1 to demo phase 2

needs discussion and low importance

milestone changed

toby — Wed, 18 Jul 2012 13:27:42 GMT

milestone changed from demo phase 2 to demo phase 3

status changed; resolution set

aron.carroll — Thu, 26 Jul 2012 15:49:55 GMT

status changed from assigned to closed
resolution set to fixed