http://localhost/ticket/2605 <p> From DR at DGU </p> <p> Basically get_groups() appears to cache its results, but this falls down when subsequent calls are in a different session. We get this when saving a dataset. get_groups() first gets called in the controller when it is trying to work out what permissions the user has. It later gets called, and by this time c.userobj is detached, so get_groups() fails. </p> <p> I'm working around this by refreshing c.userobj (from c.user) before calling get_groups(), but I wonder if the get_groups caching could detect the detached session and bypass the cache in this case? </p> <p> diff --git a/ckan/tests/models/test_user.py b/ckan/tests/models/test_user.py index a49759a..ffd3449 100644 --- a/ckan/tests/models/test_user.py +++ b/ckan/tests/models/test_user.py @@ -52,3 +52,50 @@ class <a class="missing wiki">TestUser?</a>: </p> <blockquote> <p> out = model.User.get(u'http:/sandra.owndomain.com/') assert out assert out.fullname == u'Sandra' </p> </blockquote> <p> + +def to_names(domain_obj_list): + <strong>Takes a list of domain objects and returns a corresponding list + of their names.</strong> + objs = [] + for obj in domain_obj_list: + objs.append(obj.name if obj else None) + return objs + +class <a class="missing wiki">TestUserGroups?</a>: + @classmethod + def setup_class(self): + <a class="missing wiki">CreateTestData?</a>.create_arbitrary([{'name': 'testpkg'}], + extra_user_names=['brian', 'sandra']) + <a class="missing wiki">CreateTestData?</a>.create_groups([ + {'name': 'grp1', + 'phone': '1234', + } + ]) + model.repo.new_revision() + grp1 = model.Group.by_name(u'grp1') + brian = model.User.by_name(u'brian') + model.Session.add(model.Member(group=grp1, + table_id=brian.id, + table_name='user', + capacity='admin') + ) + model.repo.commit_and_remove() + + @classmethod + def teardown_class(self): + model.repo.rebuild_db() + + def test_get_groups(self): + brian = model.User.by_name(u'brian') + groups = brian.get_groups() + assert_equal(to_names(groups), <a class="missing wiki">grp1?</a>) + assert_equal(groups<a class="missing changeset" title="No default repository defined">[0]</a>.extras, {'phone': '1234'}) + + # check cache works between sessions + model.Session.expunge_all() + #don't refresh brian user since this is how c.user works + # i.e. don't do this: brian = model.User.by_name(u'brian') + groups = brian.get_groups() + assert_equal(to_names(groups), <a class="missing wiki">grp1?</a>) + assert_equal(groups<a class="missing changeset" title="No default repository defined">[0]</a>.extras, {'phone': '1234'}) + </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/2605 Trac 0.12.3 ross Wed, 27 Jun 2012 10:30:46 GMT http://localhost/ticket/2605#comment:1 http://localhost/ticket/2605#comment:1 <ul> <li><strong>status</strong> changed from <em>new</em> to <em>accepted</em> </li> <li><strong>description</strong> modified (<a href="/ticket/2605?action=diff&amp;version=1">diff</a>) </li> </ul> Ticket ross Thu, 28 Jun 2012 09:01:50 GMT http://localhost/ticket/2605#comment:2 http://localhost/ticket/2605#comment:2 <p> Seeing *very* strange behaviour here with the tests working fine when run individually, but when run as part of the entire suite it is returning an old group (called david) that is NOT in the database (set breakpoint, queried db, not there). </p> <p> Hoping Mr Raznicks sqlalchemy skills will be able to see what is going on with this. </p> Ticket ross Tue, 24 Jul 2012 10:46:07 GMT http://localhost/ticket/2605#comment:3 http://localhost/ticket/2605#comment:3 <p> Make a decision on how we can test this cleanly and get it into 1.8 </p> Ticket ross Tue, 24 Jul 2012 10:56:09 GMT http://localhost/ticket/2605#comment:4 http://localhost/ticket/2605#comment:4 <ul> <li><strong>status</strong> changed from <em>accepted</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> <p> Code for the CTE fix is in master ready for 1.8 branch. </p> Ticket