CKAN: Ticket #2639: Update recline version for 1.8 release

status changed

amercader — Mon, 09 Jul 2012 14:57:03 GMT

status changed from new to accepted

priority changed

amercader — Tue, 10 Jul 2012 12:01:07 GMT

priority changed from major to awaiting merge

cc set

amercader — Thu, 26 Jul 2012 10:15:11 GMT

cc rgrp, icmurray added

Merged into master before 1.8. There are a couple of issues with that need to be fixed on recline code base:

Filter does not fire the state change event (Embed URL does not get updated)

https://github.com/okfn/recline/issues/195

File format not saved in Dataproxy state (Embed fails with dataproxy files with no extension)

https://github.com/okfn/recline/issues/196

When we fix these on recline we can update the build on ckan core.

rgrp — Thu, 16 Aug 2012 13:54:50 GMT

#196 is fixed. Not sure about #195. Otherwise think we are good to go.

rgrp — Thu, 16 Aug 2012 13:55:44 GMT

There is also an additional issue which is that recline no longer uses elasticsearch_url so we will need to patch this either in js or in the controller code for the embed ...

rgrp — Thu, 16 Aug 2012 19:41:27 GMT

Also found that previous recline setup used elasticsearch_url in recline 'state' (dataset part) when generating embed_url for dataset. But recline no longer supports this so move to url attribute of dataset attribute of state.

rgrp — Thu, 16 Aug 2012 19:44:49 GMT

Port of fix for recline issue 196 in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf

Fix of embed issue in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf

amercader — Fri, 17 Aug 2012 16:38:21 GMT

Added some new comments to #195:

https://github.com/okfn/recline/issues/195

status changed; resolution set

amercader — Mon, 15 Oct 2012 10:16:45 GMT

status changed from accepted to closed
resolution set to fixed