CKAN: Ticket #2661: delete dataset/group javascript confirm

toby — Wed, 11 Jul 2012 13:45:27 GMT

@aron,

we only can delete - see button if we have permission

if you make logic/auth/delete.py package_delete() return {'success': True} then it will give everyone the permission - useful for testing

aron.carroll — Thu, 12 Jul 2012 11:29:38 GMT

Styled in c165639

Toby, it would be good to display a flash message once the dataset has been deleted.

summary changed

toby — Tue, 17 Jul 2012 08:50:34 GMT

summary changed from prettify delete dataset to delete dataset/group javascript confirm

@aron,

flash messages added

I've changed these to being done via form

javascript action:

on click delete button display dialog

confirm -> set hidden input name=confirm_delete value -> "yes" submit form

no -> stop form submit

hope that makes sense if not shout

need this for dataset/group will also need for resource/related at some point soon

aron.carroll — Tue, 17 Jul 2012 11:28:45 GMT

Implemented in d980ec7. But we really need to go over the delete implementation as it could be much cleaner.

toby — Thu, 19 Jul 2012 08:18:19 GMT

@aron

can you change this so that we now post to the href if confirmed

should then work for group, dataset, related

resource will pretend to work but not actually delete yet

toby — Thu, 19 Jul 2012 16:41:10 GMT