CKAN: Ticket #2682: CKAN's internal tracking counts each view twice, needs unit tests http://localhost/ticket/2682 <p> CKAN's internal tracking seems to count each page view twice, the problem appears to be with the SQL in the update_tracking() method in ckan/lib/cli.py. </p> <p> The internal tracking feature needs some tests, and some of the code could maybe do with some more explanatory comments, e.g. what is the intended difference between count and running_total? </p> en-us CKAN http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/2682 Trac 0.12.3 seanh Mon, 16 Jul 2012 13:49:58 GMT type changed http://localhost/ticket/2682#comment:1 http://localhost/ticket/2682#comment:1 <ul> <li><strong>type</strong> changed from <em>enhancement</em> to <em>defect</em> </li> </ul> Ticket seanh Mon, 16 Jul 2012 14:02:44 GMT http://localhost/ticket/2682#comment:2 http://localhost/ticket/2682#comment:2 <p> Note that this commit fixes the double-counting for page views: </p> <p> <a class="ext-link" href="https://github.com/okfn/ckan/commit/5739818a528bb16748f67b6d57a16f575ae78144"><span class="icon">​</span>https://github.com/okfn/ckan/commit/5739818a528bb16748f67b6d57a16f575ae78144</a> </p> <p> but not for resource downloads (which look like they could have the exact same fix) but I'm not particularly happy about the fix because I don't fully understand the SQL. </p> <p> It still needs unit tests and to be fixed properly, for both pages and resources </p> Ticket seanh Tue, 17 Jul 2012 17:19:33 GMT status changed; owner set http://localhost/ticket/2682#comment:3 http://localhost/ticket/2682#comment:3 <ul> <li><strong>owner</strong> set to <em>seanh</em> </li> <li><strong>status</strong> changed from <em>new</em> to <em>assigned</em> </li> </ul> <p> Talked with kindly, seems the above fix is correct and should be applied to resources as well </p> Ticket seanh Tue, 24 Jul 2012 16:46:13 GMT priority changed http://localhost/ticket/2682#comment:4 http://localhost/ticket/2682#comment:4 <ul> <li><strong>priority</strong> changed from <em>awaiting triage</em> to <em>awaiting merge</em> </li> </ul> Ticket seanh Wed, 25 Jul 2012 14:13:56 GMT status changed; resolution set http://localhost/ticket/2682#comment:5 http://localhost/ticket/2682#comment:5 <ul> <li><strong>status</strong> changed from <em>assigned</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> Ticket