CKAN: Ticket #2701: add comments to datasets

owner, status, milestone changed; cc set

aron.carroll — Thu, 02 Aug 2012 15:11:27 GMT

cc shevski added
owner changed from aron.carroll to toby
status changed from new to assigned
milestone changed from demo phase 4 to demo phase 3

I've updated the disqus extension (in development branch) and added the snippet to the development branch of the demo plugin.

Toby, not sure about the way the disqus plugin is implemented via a helper vs the spacial plugin using a snippet. Would be good to decide on the "one" way to do this.

status changed; resolution set

aron.carroll — Thu, 02 Aug 2012 15:11:54 GMT

status changed from assigned to closed
resolution set to fixed

BTW moved this to phase three as I consider it done.

toby — Thu, 02 Aug 2012 23:24:10 GMT

Would be good to decide on the "one" way to do this.

As the new extension guru/deity I say helper functions are the future - my word is the law

a) a missing helper just returns so they can be added to templates even when not implemented, a missing template gives a 500

b) helper functions hide the implementation which I think is a good thing

c) helpers are just soooooooo cool - plus they are new and shiny (what am I saying?)

As far as moving the phase I'm not too fussed we can be ahead on phase 4

toby — Thu, 02 Aug 2012 23:25:13 GMT

track is shit - missing helpers return ''