http://localhost/ticket/2915 <p> Having two methods form_to_db_schema(self) and form_to_db_schema_options(self, options) seems unnecessary, why not just have form_to_db_schema(self, options=None)? </p> <p> Fixing this might break existing extensions although I don't think any are using form_to_db_schema_options() so it should be okay. </p> <p> The same thing goes for db_to_form_schema_option(). </p> <p> Also why are we passing a dict 'options' that always contains the same three keys 'api', 'context' and 'type'? Why not three params api=None, contenxt=None, type=None? </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/2915 Trac 0.12.3 seanh Wed, 12 Sep 2012 10:59:34 GMT http://localhost/ticket/2915#comment:1 http://localhost/ticket/2915#comment:1 <ul> <li><strong>description</strong> modified (<a href="/ticket/2915?action=diff&amp;version=1">diff</a>) </li> </ul> Ticket seanh Wed, 12 Sep 2012 10:59:48 GMT http://localhost/ticket/2915#comment:2 http://localhost/ticket/2915#comment:2 <ul> <li><strong>description</strong> modified (<a href="/ticket/2915?action=diff&amp;version=2">diff</a>) </li> </ul> Ticket