Changes between Version 2 and Version 6 of Ticket #460


Ignore:
Timestamp:
09/26/10 08:45:02 (4 years ago)
Author:
rgrp
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #460

    • Property Priority changed from awaiting triage to critical
    • Property Milestone changed from to ckan v1.3
    • Property Owner set to pudo

  • Ticket #460 – Description

    v2 v6  
    66 1. created by Richard (logged-in) 
    77 2. edited by Richard (logged-in) 
    8 (According to the logs, at this point the state was changed from 'active' to 'deleted) 
     8(According to the logs, at this point the state was changed from 'active' to 'deleted') -- RP was it set to 'deleted' or just ''? 
    99 3. pudo changed the state back to active 
    1010 
    11 Richard is not a sysadmin, so shouldn't have been able to see or change the state. Need to investigate how this got changed, fix if necessary and report back to Richard. 
     11Similarly an incident with bibbase package where field set to '' (see http://ckan.net/revision/diff/bibbase?diff=702bb0a3-03b7-49ac-87ad-e489c414962f&oldid=5447842d-b6ed-41d9-9cfd-8bb73b85c409) 
     12 
     13Need to investigate how this got changed, fix if necessary and report back to Richard. Note that package 'admins' as well as sysadmins can change the state of a package (though note that bibbase did not appear to have an owner). 
     14 
     15Suggested solution (for setting to ''): 
     16 
     17  * Ensure in ckan/forms.py that there is a validator for state field that ensures only set to valid values. 
     18  * Check that we do not allow state to be changed in the api except by package owner or sysadmin