CKAN: Ticket #840: On/off switch for ETags cache

dread — Thu, 02 Dec 2010 21:27:31 GMT

dread:

] That's the proxy_cache decorator which sets a Beaker expiry time only. ] Whether that is on or off, you still end up run the ] "etag_cache(cache_key)" command in the package controller won't you? ] And won't that will either insert the Etags header or abort 304 for a ] repeat? I must admit I've not tried it, asking purely with the code in ] front of me and welcome you pointing out where I've gone wrong.

ww:

Right. So those etag calls predate the cache decorators and should probably be either moved up into the decorator (e.g. use @ckan_cache instead of @proxy_cache) or wrapped in a check for the config parameter. (And @ckan_cache could be changed to use pylons' etag_cache function rather than just setting the header...)

owner changed

dread — Fri, 03 Dec 2010 13:00:15 GMT

owner changed from pudo to ww

owner changed

thejimmyg — Fri, 07 Jan 2011 16:11:53 GMT

owner changed from ww to wwaites

owner changed; repo, theme set

dread — Wed, 13 Apr 2011 10:49:15 GMT

owner changed from wwaites to dread
repo set to ckan
theme set to none

status changed; resolution set

dread — Wed, 13 Apr 2011 11:28:43 GMT

status changed from new to closed
resolution set to fixed

Basic on/off switch added, tested & documented in cset:0da189c9630e on default.

milestone set

dread — Wed, 13 Apr 2011 11:28:53 GMT

milestone set to ckan-v1.4-sprint-6