http://localhost/ticket/917 <p> David Raznik: I propose we remove autoflush by default in ckan. It caused a lot of bugs on the version upgrade due to its magical behavior. </p> <p> I have a patch in <a class="ext-link" href="https://bitbucket.org/kindly/ckan/"><span class="icon">​</span>https://bitbucket.org/kindly/ckan/</a> on branch feature_switch_autoflush_off_by_default. </p> <p> This change simplifies code. It only took 7 extra flushes/commits to make work and there are over 40 instances that we remove autoflush, so as not to cause error (I have not removed them in the patch yet). </p> <p> Things to know about using flush: </p> <ul><li>Most of the time nothing will change. A commit implies flush. </li><li>You only need to flush if you expect a query to return an object you just saved. i.e if you session.add(obj) and you expect obj to be in a session.query. </li><li>A flush is handy when you want to get the primary key out before you do a commit. i.e session.add(obj); session.flush(); obj.id is now generated. </li><li>You can use them as a limited form of nested transaction. </li></ul><p> It increased the performance on the tests by about 5%. There are less flushes altogether so is faster. </p> <p> I do not see any downsides. </p> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/917 Trac 0.12.3 dread Mon, 17 Jan 2011 16:03:00 GMT http://localhost/ticket/917#comment:1 http://localhost/ticket/917#comment:1 <ul> <li><strong>owner</strong> set to <em>kindly</em> </li> <li><strong>reporter</strong> changed from <em>dread</em> to <em>kindly</em> </li> </ul> Ticket dread Mon, 17 Jan 2011 16:03:15 GMT http://localhost/ticket/917#comment:2 http://localhost/ticket/917#comment:2 <ul> <li><strong>status</strong> changed from <em>new</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> Ticket dread Mon, 17 Jan 2011 16:03:52 GMT http://localhost/ticket/917#comment:3 http://localhost/ticket/917#comment:3 <p> Fixed in cset:f2865f43d8ee </p> Ticket