http://localhost/ticket/961 <p> This is a meta-ticket to hold all of the work on refactoring forms, validation and model-synchronization in CKAN. </p> <p> ckan-dev thread: <a class="ext-link" href="http://lists.okfn.org/pipermail/ckan-dev/2011-January/000180.html"><span class="icon">​</span>http://lists.okfn.org/pipermail/ckan-dev/2011-January/000180.html</a> </p> <h2 id="TheIssue">The Issue</h2> <p> From <a class="closed ticket" href="http://localhost/ticket/926" title="enhancement: Pick a simpler form framework (closed: fixed)">#926</a>: </p> <p> The current formalchemy setup conflates view, controller and model code in a way that makes it hard to debug and customise. </p> <p> From <a class="ext-link" href="http://lists.okfn.org/pipermail/ckan-dev/2011-January/000181.html"><span class="icon">​</span>http://lists.okfn.org/pipermail/ckan-dev/2011-January/000181.html</a>: </p> <p> ... FormAlchemy, in retrospect, was probably a mistake as it merges too much model/validation/form generation into one thing. </p> <p> At least 3 functions involved [in this area]: </p> <ol><li>Generating (or just filling) a form template with 'form data' (and errors) </li><li>Converting model data to form data (also happens for APIs in fact) -- let's call this 'dict-ization' </li><li>Converting form data to model data (and validating) (inverse of previous step) </li></ol><h2 id="RelatedTickets">Related Tickets</h2> <ul><li><a class="closed ticket" href="http://localhost/ticket/926" title="enhancement: Pick a simpler form framework (closed: fixed)">#926</a> - Pick a simpler form framework </li><li><a class="closed ticket" href="http://localhost/ticket/1046" title="enhancement: Dictization and the new logic layer (closed: fixed)">#1046</a> 'dictization' and the logic layer - serialization / deserialization of package (and other domain objects) to standard intermediate format such as json-convertable python dict <ul><li>Refactor API to use new logic layer and dictization <a class="closed ticket" href="http://localhost/ticket/1079" title="enhancement: Refactor API to use new logic layer and dictization (closed: fixed)">#1079</a> </li><li>Refactor WUI controllers and forms to use logic layer - <a class="closed ticket" href="http://localhost/ticket/1078" title="enhancement: Refactors WUI controllers and forms to use logic layer (closed: fixed)">#1078</a> </li><li>cf existing dumper and importer code </li><li>This will fix <a class="closed ticket" href="http://localhost/ticket/662" title="defect: Can't put entity that is returned by posting to package register (closed: fixed)">#662</a> </li></ul></li><li>[not ticketed yet] - validation layer (should work on serialized objects?) </li><li><a class="closed ticket" href="http://localhost/ticket/662" title="defect: Can't put entity that is returned by posting to package register (closed: fixed)">#662</a> - Can't put entity that is returned by posting to package register (Defect) </li><li><a class="closed ticket" href="http://localhost/ticket/972" title="enhancement: Merge 'extras' into main package dict rather than having separate key (closed: wontfix)">#972</a> - Merge 'extras' into main package dict rather than having separate key </li><li><a class="closed ticket" href="http://localhost/ticket/1035" title="enhancement: Form impressions given an ID (closed: wontfix)">#1035</a> - Form impressions are given IDs </li><li><a class="closed ticket" href="http://localhost/ticket/810" title="enhancement: Move &#34;add packages&#34; field up in group form (closed: wontfix)">#810</a> - Move "add packages" field up in group form (easier to do this once forms are done) </li></ul> en-us http://assets.okfn.org/p/ckan/img/ckan_logo_shortname.png http://localhost/ticket/961 Trac 0.12.3 dread Mon, 07 Feb 2011 10:14:18 GMT http://localhost/ticket/961#comment:1 http://localhost/ticket/961#comment:1 <p> So you also need: </p> <ol start="4"><li>Converting form data to dict </li><li>Converting dict to model </li></ol><p> i.e. the dict is not the same as the serialized form data or model data. </p> Ticket rgrp Thu, 10 Feb 2011 10:05:03 GMT http://localhost/ticket/961#comment:2 http://localhost/ticket/961#comment:2 <ul> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=2">diff</a>) </li> </ul> Ticket sebbacon Mon, 28 Feb 2011 09:20:44 GMT http://localhost/ticket/961#comment:3 http://localhost/ticket/961#comment:3 <ul> <li><strong>milestone</strong> changed from <em>ckan-v1.4-sprint-1</em> to <em>ckan-v1.4-sprint-3</em> </li> </ul> Ticket dread Fri, 11 Mar 2011 15:39:58 GMT http://localhost/ticket/961#comment:4 http://localhost/ticket/961#comment:4 <ul> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=4">diff</a>) </li> </ul> Ticket rgrp Mon, 14 Mar 2011 09:09:41 GMT http://localhost/ticket/961#comment:5 http://localhost/ticket/961#comment:5 <ul> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=5">diff</a>) </li> </ul> Ticket rgrp Thu, 24 Mar 2011 14:55:02 GMT http://localhost/ticket/961#comment:6 http://localhost/ticket/961#comment:6 <ul> <li><strong>repo</strong> set to <em>ckan</em> </li> <li><strong>theme</strong> set to <em>none</em> </li> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=6">diff</a>) </li> </ul> Ticket rgrp Mon, 28 Mar 2011 09:47:51 GMT http://localhost/ticket/961#comment:7 http://localhost/ticket/961#comment:7 <ul> <li><strong>owner</strong> changed from <em>sebbacon</em> to <em>kindly</em> </li> <li><strong>summary</strong> changed from <em>Refactoring of forms, validation and model synchronization</em> to <em>[super] Refactoring of forms, validation and model synchronization</em> </li> <li><strong>milestone</strong> changed from <em>ckan-v1.4-sprint-3</em> to <em>ckan-v1.4</em> </li> </ul> Ticket rgrp Mon, 11 Apr 2011 08:12:53 GMT http://localhost/ticket/961#comment:8 http://localhost/ticket/961#comment:8 <ul> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=8">diff</a>) </li> </ul> Ticket rgrp Mon, 11 Apr 2011 08:13:20 GMT http://localhost/ticket/961#comment:9 http://localhost/ticket/961#comment:9 <ul> <li><strong>description</strong> modified (<a href="/ticket/961?action=diff&amp;version=9">diff</a>) </li> </ul> Ticket rgrp Thu, 16 Jun 2011 13:14:18 GMT http://localhost/ticket/961#comment:10 http://localhost/ticket/961#comment:10 <p> @kindly: can we close this ticket now. All the meat is done and the remaining related tickets are either low priority or possibly wontfix. </p> Ticket shevski Fri, 08 Jul 2011 11:55:00 GMT http://localhost/ticket/961#comment:11 http://localhost/ticket/961#comment:11 <ul> <li><strong>status</strong> changed from <em>new</em> to <em>closed</em> </li> <li><strong>resolution</strong> set to <em>fixed</em> </li> </ul> <p> The main parts of this ticket are now done. The remaining parts can be dealt with separately as their own tickets. </p> Ticket