{23} Trac comments (3729 matches)

Results (1 - 100 of 3729)

1 2 3 4 5 6 7 8 9 10 11 →
Ticket Posixtime Author Newvalue
#3029 1355243824000000 dread Fix done here: https://github.com/datagovuk/ckan/commit/b6ad63d58dd6c0cc51677fa66c575179f908d050 which you're welcome to pull.
#3021 1353411968000000 johnmartin In code review
#3018 1355140950000000 seanh https://github.com/okfn/ckan/pull/171
#3007 1351517019000000 seanh Only happens if you create a dataset through the web UI, creating a dataset through the API still produces just one activity.
#2980 1350560137000000 seanh Won't do unless required by a specific client
#2968 1350297070000000 seanh This also applies to other pages such as /member_new and /member_delete
#2956 1349278531000000 johnmartin OK, this was simple... I just added an already made snippet to the page. Ira: Can you confirm that the attached screenshots satisfy fixing the problem?
#2956 1349346442000000 shevski This needs to be a navigation menu item that includes both the name & link to the dataset edit page and then underneath (nested) the links to it's resources - so that the user can easily move between the dataset edit pages and resource edit pages and know where they currently are (using the selected pointer style)
#2953 1349257893000000 toby awaiting merge https://github.com/okfn/ckan/pull/145
#2951 1349168981000000 toby the files like red.css should also be done as part of this. and before minification of files - should really be part of same process
#2950 1349168838000000 toby just a note to say fanstatic will serve minified files if it finds them in production even if they are old so we need to make sure they are up to date.
#2942 1348610791000000 dread Unfortunately with a few hours hacking I couldn't find a way to get this version of WebOb to cope with this header. The line I think it goes wrong is {{{ctype = env.get('CONTENT_TYPE', 'application/x-www-form-urlencoded')}}} in request.py, and the commented line above looks right, but wipes the request data for some reason. I tried intercepting the bad header and deleting it, but I couldn't do that before WebOb processed it, and couldn't persuade WebOb to reprocess it once the header was edited. I did write a failing test though if that is useful to someone in the future: {{{ diff --git a/ckan/tests/functional/api/test_api.py b/ckan/tests/functional/api/t index 539d184..b4cc4ce 100644 --- a/ckan/tests/functional/api/test_api.py +++ b/ckan/tests/functional/api/test_api.py @@ -49,6 +49,18 @@ class TestApi3(Api3TestCase, ApiTestCase): assert_in('Bad request - JSON Error: No request body data', res.body) + def test_content_type_headers_can_be_sent(self): + '''#2942 Webob can only cope with very specific Content-Type header + values, so this tests that a work-around is in place. + + This particular header value is the default for 'requests' 0.14. + ''' + offset = self.offset('/action/package_search') + params = '%s=1' % json.dumps({'q': 'russian'}) + headers = {'Content-Type': '; charset=utf-8'} + res = self.app.post(offset, params=params, headers=headers, + status=[200]) + }}} There is a clear error to the user: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}').content '"Bad request - JSON Error: Could not extract request body data: Bad content type: \'; charset=utf-8\'"' }}} The advice to users of requests would be to ensure they specify the content-type as follows: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/x-www-form-urlencoded'}).content }}}
#2942 1348611144000000 dread > {{{ > >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/x-www-form-urlencoded'}).content > }}} Or even better: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/json'}).content }}}
#2937 1348157780000000 seanh This is fixed on master (commit e97b5c70e9325a1095778fef8e0d27c84e881b30) needs to be cherry-picked into 1.8
#2937 1348238875000000 seanh Cherry-picked into 1.8
#2934 1347969321000000 dominik This looks promising but seems to be discontinued: http://twill.idyll.org/python-api.html
#2934 1348060201000000 dread The functional tests actually do cover a logged in person editing a dataset and then checking it displays correctly in the view page again. The webtest framework we use in CKAN has form filling and link click() function which allows navigation between pages like you describe these other ones having too. Having said that, there is no reason why a newer library shouldn't be introduced if webtest is not sufficient. And if there are stories without tests then it would be good to add them.
#2931 1347891378000000 seanh Also set_global() seems to have the wrong docstring
#2913 1350303779000000 seanh Moving into 2.0 milestone. Also affects 1.8.
#2907 1352206307000000 johnmartin Fixed in master
#2906 1346862889000000 shevski fixed by removing custom css from the stylesheet, but should look into why it happened
#2900 1346335788000000 seanh Why does this only happen on user profile pages and not dataset search page or group read page? Looks like maybe only user profile page uses the package_list.html snippet
#2890 1346175867000000 rgrp I know this is tricky. The issue is that Datastore does not exist *just* to provided data views - it also provides a bunch of other stuff like a Data API and, well, a Datastore. I also think there are different audiences. Data view info is about publishers and (viewing) users, while the Data API is for (non-CKAN) devs and CKAN devs and the Datastore sysadmin section is for deployers. My feeling is therefore keeping things as is but with more stuff in the Data View seciton about it all works: * Data viewer: explanation for publisher, links to next 2 sections * Datastore page (as we have it) * Includes datastorer * Using Data API page (as we have it) So main change is a better data viewer page ...
#2885 1345625524000000 seanh authz_form_table() in ckan/templates/package/authz.html creates a table with non-translatable labels (anon_editor, admin, editor, reader...)
#2883 1345629890000000 seanh Also see the thread here: http://lists.okfn.org/pipermail/ckan-discuss/2012-August/002382.html the questions asked in the thread should give ideas what to add to the overview
#2881 1345626056000000 rgrp @seanh - this was the material from the wiki moved to the docs. I agree it is somewhat incomplete but we certainly shouldn't remove it without something better in place. Also, IMO this is currently very low priority ...
#2880 1350561968000000 seanh Closing as we've moved forward with a slightly different approach to organizations in core instead.
#2879 1350562096000000 seanh Closing as we've moved forward with a slightly different approach to organizations
#2878 1350561906000000 seanh Closing as we've gone forward with a slightly different approach instead
#2877 1345600430000000 kindly 1. This is fixed need to reload data to test though. 2. Fixed as far as I am concerned, limit 0 now returns correct total. If there are no results in filter return total of 0. 3. Want to keep postgres types. This will stop the need for mappings in both directions and makes everything simpler. We are currently not storing any metadata on tables and would like it to stay that way.
#2873 1345129315000000 danieljohnlewis For example see: http://s031.okserver.org:2375/qa/dataset/five_stars Which has: Example dataset as a score of: 4 After examination of the dataset ( http://s031.okserver.org:2375/dataset/example-dataset ) it is made up of a CSV and an HTML file.
#2873 1345136489000000 toby This is a problem with the summary data not the resource qa score it is almost certainly due to stale data. keeping here till resolved
#2873 1345208283000000 toby qa extension is crap and needs fixing to work properly due to where it stores data (in the task status - wtf)
#2872 1350304179000000 seanh Just tested and this seems fixed so closing
#2865 1345131215000000 ross Can't replicate locally in either master or release-v1.8 /el/ isn't a valid locale, and so the problem is unicode in urls where ckan is trying to generate a 404.
#2863 1345122384000000 toby @ira, This is actually working correctly but the permissions on the server s031 are not what you want I do not know how or where these are defined - he has package_update permissions from somewhere maybe ross or someone knows
#2863 1345122876000000 ross This is changeable in config. The default permissions are specified in there I believe.
#2863 1345123824000000 shevski If by default it doesn't happen, then that's fine & we can close this. Any way for me to see how permissions are set?
#2863 1345123978000000 ross No idea :| The perms are commented out by default in the template ini file. You should take a look at the ini file and see how it is setup, search for ckan.default_roles.Package but I can't see how Daniel would have been granted read access without the auth pages being implemented.
#2863 1345201502000000 toby @ira, I am moving this to phase 4 as it's not going to be looked at till the new permissions stuff is agreed
#2857 1345107097000000 toby dashboard hidden in phase 3 we can fix up in phase 4
#2856 1345049793000000 shevski server error URL: http://s031.okserver.org:2375/apps/49a509f7-4eb6-456f-b1fc-87cfde90c60d
#2856 1345107503000000 toby fixed now gives 404 The issue of not wanting a 404 is outside the scope of this ticket as it's a whole activity stream issue and needs dev buy in etc
#2855 1345103314000000 toby @ira, this works for me at the given link try refreshing the page in case it's a cache issue
#2855 1345104178000000 shevski I cleared my cache and it's working now
#2853 1345049201000000 amercader The message it is pretty self-explanatory, but I'm happy to lower it to warning. We can't know the scheduled time because it depends on how is set up on the server (generally a cron job every x minutes).
#2853 1345103841000000 toby @ira, I'll change to notice will do for the other one too
#2853 1345104231000000 toby @both notices now blue
#2852 1345103409000000 toby @ira, Please review the fix I think adriá did
#2852 1345103634000000 toby I think it should stay red but you can argue
#2852 1345104027000000 shevski Red is fine here Can we amend the message to: Cannot create new harvest jobs on inactive sources. First, please change the source status to 'active'.
#2852 1345106515000000 toby text updated and red again
#2844 1345454527000000 toby paster db clean fixed in https://github.com/okfn/ckan/pull/107
#2843 1345035045000000 ross Add existing dataset doesn't make a lot of sense because they can only belong to a single organization. Best would be to fix the organisation template to remove Add Existing.
#2841 1344857415000000 aron.carroll Fixed in a317fb9
#2840 1344852538000000 aron.carroll Fixed in f7bc1c9. This can be flipped back by adding a class of {{{.tagline-right}}} to the hgoup element.
#2839 1344854522000000 toby this is fixed in https://github.com/okfn/ckan/pull/88
#2837 1344847463000000 aron.carroll Checkboxes created with {{{ form.checkbox() }}} should be styled correctly. Got a link to an example?
#2837 1344847819000000 toby http://localhost:5000/testing/primer essentially it's a black not grey outline also errored one isn't red
#2837 1344851271000000 aron.carroll Fixed alignment issues in Firefox as of a6fa5a0. Can't do anything about visual display of checkboxes as they're controlled by the vendor. We could replace them with images, if this is going to be required then please create a new ticket for the next phase.
#2836 1344852009000000 aron.carroll Yeah you can pass an html block into a macro like so: https://github.com/okfn/ckan/blob/2375-demo-theme-development/ckan/templates/package/snippets/resource_form.html#L44-48 What do you think? If it's useful I'll document it.
#2836 1344853957000000 toby @aron, I'd love it if we could pass it as an arg ie form.input(...., extra_info=<something escaped if not literal()>) also while we're at it I'd also really like form.input(...., help_info=<something>) that would give a (?) icon with a :hover {display:block} div - that make sense?
#2836 1344859911000000 toby I'd quite like some general css like this <span class="hover-for-help">[thing to hover over] <div class="help-text">Help text</div> </span> This is for the qa extension but seems like a general need .hover-for-help .help-text{ display:none; } .hover-for-help:hover .help-text{ display:block; position:absolute; padding:3px; }
#2834 1344856692000000 aron.carroll Done in 092d257
#2832 1344542984000000 toby duplicate of #2718 closing
#2828 1344507533000000 toby @ira this is the correct behaviour as this is a partially added dataset - rewritten ticket as it has a nice number :)
#2827 1344549139000000 toby Fixed and pushed to s031
#2826 1344527309000000 shevski @Toby do you know what's happened? Don't think this was the case before. Should pre-fill with standard image when there's no group image URL
#2826 1344528004000000 toby fixed, issue was url_for_static @ira, good to test the site in english ie url like /en/dataset change language to something then english it will help catch these issues
#2824 1344527130000000 shevski @aron any ideas?
#2824 1344532640000000 aron.carroll All fixed
#2819 1344545479000000 toby works in dev branch for /apps http://localhost:5000/dataset/1-kmwaterfractionfromnationaltopographicdatabasemapscanada/related
#2818 1344545331000000 toby check schema
#2818 1345482572000000 toby @ross, This is an issue with the related items schema - I'm not quite sure what all the rules should be eg does visulisation need image url? or is normal url ok? Could you review the schema and ensure that we require/don't require the correct items. If you provide the rules I can help do the schema if you want but I don't know them cheers Toby
#2818 1345485131000000 ross URL should be required, image url isn't required.
#2818 1346231718000000 ross Has been suggested that we are clearer on why the URL is required, as this related items are really just 'Links'. We should consider the name change, and also possibly make the types configurable in config somewhere as they are currently almost content free. Assigned to Sean to keep an eye on this ticket until we get a reasonable chance to action it.
#2817 1344544901000000 toby works in dev branch - may not be on s031 yet also please include urls in bug reports if possible - thanks
#2814 1346670381000000 ross Have assigned to client team to decide what they want to do about this.
#2813 1344445419000000 toby http://demo.ckan.org/dataset/afterfibre group box wants a title link is not clickable maybe reorder stuff
#2812 1344445200000000 toby @ira, do you want this change?
#2812 1344507240000000 shevski Current text does need updating, but I think we need an explanation along the lines of: "Groups allow you to group together datasets under a organisation (for example, the Department of Health) or topic (e.g. Transport, Health) so make it easier for users to browse datasets by theme. Groups also enable you to assign roles and authorisation to members of the group - i.e. individuals can be given the right to publish datasets from a particular organisation." But even that could be clearer. Mark's text could be misleading since we haven't currently implemented private datasets or the right auth settings.
#2812 1344509156000000 toby changed
#2812 1344521102000000 markw That's still fairly terrible. Also surely the auth stuff is part of Ross's Organizations stuff? It doesn't matter much if it's implemented yet, that's why this is a demo. But anyway, here is a more generic but readable version based on Ira's text above: Groups allow you to group users and data together so that they are easier to manage. Group owners can assign roles and authorisations, giving each project or department control of its own data publishing. Users can browse or search by group, making it easier to find the data they are looking for.
#2812 1344523785000000 toby @markw I think you are talking about a different ticket closing
#2812 1344524290000000 toby @markw, Actually I see you also want some text changes please don't add unrelated discussions to tickets as it causes noise is disruptive and I just end up closing tickets as won't fix etc. I have updated the text as it was assigned to me and so i am still keeping this closed as I did as requested. Can you an ira sort this out between yourselves and create a new ticket when you have agreement Thanks
#2811 1349869110000000 amercader Fixed on master, 1.8 and 1.7.2
#2809 1344347814000000 aron.carroll Fixed in 84a4123
#2808 1344944258000000 aron.carroll Close in 97d92ba
#2807 1344270190000000 aron.carroll Fixed in 9a6d0be
#2806 1352206005000000 johnmartin Fixed with new group pages.
#2805 1344254760000000 toby Arg I think this is my fault
#2804 1344269865000000 aron.carroll Done in 38f824b
#2803 1344256274000000 aron.carroll Done in 3b2427e
#2802 1344258233000000 toby @aron I've done most of this to test get strings {{{ python setup.py extract_messages }}} mangle the zh_TW creates .po/.mo files - I may need to fix plurals {{{ paster trans mangle -c .ini }}} create .js files only zh_TW will be correct due to other .po/.mo files being 1.7 ones {{{ paster trans js -c .ini }}} /api/i18n/zh_TW should be correct please note we do not have en.js I'm returning {} I think this is the correct response (maybe something else as we should just use the default _('...') strings - maybe we need to do something else for what it's worth pojson does not provide the format you wanted so I adapted it reassign if you need fixes
#2802 1344269446000000 aron.carroll Cool, this is in as of 8b72d1f8e9ba
#2801 1344526607000000 shevski @Aron / Ross is it worth having a separate page for related items? E.g. like on pd.eu http://publicdata.eu/app/irail
#2801 1344526719000000 aron.carroll Not sure it is. I'm just implementing a toggle on description so it works the same way as on the datahub.
#2801 1344531016000000 aron.carroll Now able to display the full text of related items as of e83df46
#2797 1344250973000000 aron.carroll Just a classname issue. Fixed in f927598 and documented
#2796 1345129471000000 shevski Some notes already here: http://ckan.okfnpad.org/datahub-faq
1 2 3 4 5 6 7 8 9 10 11 →
Note: See TracReports for help on using and creating reports.