{23} Trac comments (3729 matches)

Results (2201 - 2300 of 3729)

Ticket Posixtime Author Newvalue
#1294 1315948112000000 rgrp Removing #1311 as that is not directly related to dataset edit / create.
#1294 1315948257000000 rgrp Done with merge into default in cset:8bb0720a2150 and deployment to http://thedatahub.org/
#1295 1315820564000000 rgrp This is mostly done but some final tweaks and name disabling to be done. See work in feature-1294-ux-improvements-dataset
#1295 1315948009000000 rgrp Completed with merge into default in cset:8bb0720a2150
#1296 1315403275000000 zephod No longer doing inline resource editing on dataset/view; instead use the edit form.
#1296 1315821293000000 rgrp Have now done resource add pretty effectively and most of edit done (should complete today).
#1296 1315948027000000 rgrp Completed with merge into default in cset:8bb0720a2150
#1297 1315403878000000 zephod No longer doing inline editing on the view page.
#1297 1315403974000000 zephod Largely done in cset:8901e722b158
#1297 1315404322000000 zephod all done: cset:71096cd7b27d
#1298 1321199769000000 seanh I've been working on this in this branch: https://github.com/seanh/ckan/commits/feature-1298-activities-table
#1298 1323106307000000 seanh See the new super ticket and its branch: #1515
#1298 1323710593000000 dread Sean says: This is done on the activity stream branch. Just would like David Raznick to review it.
#1298 1324384191000000 seanh David, Ignore my link above to a branch on my ckan fork. Now that I have permissions I'm pushing my branches to the okfn ckan repo on github. My super branch for the activity streams feature is '''feature-1515-activity-streams''' on the okfn ckan repo on github. This page comparing my branch to master is particularly useful: https://github.com/okfn/ckan/compare/master...feature-1515-activity-streams (click on the Files Changed tab) For reviewing this ticket, the relevant changes to review are: * ckan/lib/activity.py, all of it * ckan/model/activity.py, all of it * My changes to ckan/model/meta.py * My changes to ckan/model/package.py * My changes to ckan/model/resource.py * ckan/tests/models/test_activity.py, all of it The other changes on my branch are for other activity streams tickets that follow this one. The super ticket #1515 has an overview of it all.
#1299 1325866115000000 rgrp No estimate as yet? (Or is it in super ticket? (Link?)). Also isn't this a duplicate of #1510 (or vice-versa)?
#1300 1315906283000000 rgrp page_heading and optional_footer done in #1108
#1300 1315908961000000 rgrp Move of js to optional_footer done in cset:dcb21f0d976f. As part of #1294 have done a lot of css adding. Not sure how much more to do here.
#1300 1319794520000000 rgrp Side bar menu is switchable (though not sure how -- zephod has done this!) CSS tidying and labelling of divs done in #1380. So closing!
#1303 1314978842000000 dread Adria fixed this in cset:7637d8694388 on default. I transplanted it to release-1.4.3 and have updated thedatahub.org.
#1305 1314971164000000 nils.toedtmann Always use "localhost" as mail relay. On all servers, the local MTA should be configured correctly (e.g. in this case to relay via mail.fry-it.com), also to be able to send rootmail. I fixed it on IATI (s049.okserver.org = ex eu23) and thedatahub.org (s055.okserver.org). Please verify that it's working now.
#1305 1315317033000000 nils.toedtmann [15:22:02] Adrià Mercader: Yes it looks like it works on both thedatahub.org and iatiregistry.org
#1306 1319797204000000 dread These are expressed as functional API tests - see tests/functional/api/test_action.py. There's not a lot of difference (apart from Paste coming in there) so no real need to duplicate API and logic layer tests, or to switch them to talk directly to the logic layer.
#1307 1315246706000000 zephod cset:2c31fe24e1c9
#1307 1315247298000000 zephod Replying to [comment:2 zephod]: Oops: cset:cbd6677ec41e
#1309 1315586335000000 dread Duplicate of #1318
#1310 1315820419000000 dread This was fixed cset:e49781cb74fd for 1.4.3.
#1312 1315327743000000 dread The default Content-Type is "application/x-www-form-urlencoded" (that is what curl sends, and what CKAN defaults to). Therefore these characters need url encoding ("=&;" -> "%3D%26%3B"). Here is an example of it working: {{{ (pyenv-ckan)[email protected]:~/hgroot/ckan$ curl -i http://localhost:5000/api/rest/package -d '{"name": "test7", "title": "Test2 %3D%26%3B"}' -H "Authorization:tester" HTTP/1.0 201 Created Server: PasteWSGIServer/0.5 Python/2.6.5 Date: Tue, 06 Sep 2011 16:36:32 GMT Pragma: no-cache Cache-Control: no-cache Location: http://localhost:5000/api/rest/package/5866a0f5-905a-44ff-91c3-c1489374a73e Content-Type: application/json;charset=utf-8 Content-Length: 571 {"maintainer": null, "maintainer_email": null, "id": "5866a0f5-905a-44ff-91c3-c1489374a73e", "metadata_created": "2011-09-06T14:06:40.735488", "relationships": [], "metadata_modified": "2011-09-06T16:36:32.543461", "author": null, "author_email": null, "state": "active", "version": null, "license_id": null, "resources": [], "tags": [], "groups": [], "name": "test7", "license": null, "notes_rendered": "", "url": null, "notes": null, "title": "Test2 =&;", "ratings_average": null, "extras": {}, "ratings_count": 0, "revision_id": "92ee0b2e-c5e4-47b9-b00c-b8e29662b950"} }}} Alternatively you can set the content type to "application/json" and you don't need to URL encode. e.g.: {{{ curl -i http://localhost:5000/api/rest/package -d '{"name": "test5", "title": "Test &"}' -H "Authorization:tester" -H "Content-Type: application/json;charset=utf-8" }}} To help work out these problems with encoding in the future, I've improved the error message to show the decoded JSON string. cset:55273629a552 which is headed for CKAN 1.5 release.
#1313 1317076432000000 rgrp Error was due to maintenance. Need both config options for recaptcha to work so either one can be used to check config. Re docs see #1358 (auto generation of docs on config from the config source). Given that only docs remain and that is part of #1358 am closing as duplicate.
#1315 1315414218000000 dread Pretty good start added in cset:7a0e7a486df3 on default, aiming for release 1.5. Just needs some loose ends tidying up.
#1315 1320173768000000 dread Tidied up in cset:39daf1afd64a for release 1.5.
#1316 1338193724000000 kindly now get_or_bust function handles this.
#1317 1315416649000000 dread Ok, I think this example may be when searching for "ira". "irina" works me, but "ira" gives: {{{"ira" matched several users}}}
#1317 1315822670000000 rgrp This is very minor IMO. I would defer this as part of a more general user system ux refactor.
#1317 1325473762000000 rgrp Moving out v1.6 as minor.
#1318 1315569362000000 dread Problem tracked down to Adria's cset:4f1ca1eb2630 on branch feature-1229-db-out-of-controllers that missed out repoze.who in the redirects after login, when refactoring the user registration. This code went into default on 2011-07-28 for release 1.4.3. Fixed in cset:93731cd3b22e for release 1.4.3 and doesn't affect previous releases. Tests for user registration added too.
#1319 1315476057000000 shevski Ideally we should also verify people's email addresses. Do we think that's overkill?
#1319 1315904592000000 dread No responses received about this on ckan-discuss, so I'm taking that as no objections to requiring email address on registration. I think that verifying email address is not worth it in this case, because the value of supplying an email address is only for resetting a password. The chance of needing a password reset AND having inputted an incorrect email address is very low, so I don't think it justifies everyone having to do this extra step. If we used email address more then that may change.
#1319 1318426807000000 rgrp @dread: hope it is OK to re-assign to me but this is very similar to #1386 (and is a su bticket of #1343)
#1319 1318527613000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/130cad62163c
#1319 1324036947000000 dread Goes into release 1.5.1
#1320 1317391018000000 zephod Extend misc.py to regex find http and https, surrounding it with <>. ALSO note that CKAN flavoured markdown will not currently recognise dataset:my_data links (still uses package).
#1320 1317730999000000 zephod Slightly painful when links appear inside naughty HTML tags or in markdown tags. Restriction: Links are auto-linked if they appear at the start of a line or after whitespace. cset:f9dfb0506594
#1320 1318164603000000 rgrp Completed in https://bitbucket.org/okfn/ckan/changeset/f9dfb0506594
#1321 1319558004000000 dread We should not cache if there are flash messages to show (otherwise they get queued up for the next non-cached page view). Fixed in cset:945e2a6ce74f for release 1.5
#1323 1315594333000000 dread thedatahub has a couple of auth groups with no name. The form allows it! Fixed in cset:bebd0a46ebc6 * form requires the name field * existing auth groups without name can be viewed/edited if necessary (referring by ID) This has probably been a problem since auth groups were added to CKAN.
#1324 1315948336000000 rgrp Done and merged into main at cset:8bb0720a2150 (and deployed!)
#1325 1315587113000000 dread Fixed in cset:0dd4d4457c97 for release 1.4.3. Previous Python 2.5 incompatible versions include 1.4.2 - and maybe further.
#1327 1320662446000000 rgrp Duplicate of #1397
#1328 1340191065000000 ross Let's see if this is still an issue in 1.8
#1329 1316624026000000 zephod I've tried to do this wherever I could as I looked through ckan.pot for broken pieces of string. Generally it triggers errors unless things are very neatly structured (no nested links or ${a.variable} accesses, it seems) but things are quite a lot tidier. cset:d5bf4c7ba293 Does that count as 'fixed', or is this a permenant issue?
#1329 1317118323000000 dread I'll take a look to see if I can do any more and then will close it.
#1329 1317404566000000 dread POT looks far better. I couldn't see any outstanding problems. This has gone into ckan 1.5.
#1330 1327060201000000 dread This is simply incorrect. test_authz.py (I assume you mean the one in ckan/tests/functional?) tests that authz works all across the Web UI and API in enough detail. The 'total site lockdown' test - perhaps you mean the TestLockedDownViaRoles class which makes up a small part of test_authz? It was a test added due to an untested use case implemented in IATI, DataGM etc. These are currently active so still need testing. Regarding refactoring the tests to be "proper" then please open a new ticket, providing references to why it is not "proper" to test by searching for text in a web response.
#1331 1325355631000000 dread This appears to be fixed in 1.5, 1.5.1 and 1.5.2a.
#1332 1315999104000000 dread Fixed in cset:860b357a2aec for release 1.4.3 and updated no.ckan.net. This problem was due to {{{[1:authorization group]}}} being translated as {{{[autoriseringsgruppe]}}} and I corrected it to {{{[1:autoriseringsgruppe]}}}. This word has a bold tag, hence the brackets and the number is used to identify which bracketed word is which (when you have more than one). It is a shame that Transifex doesn't draw attention to this problem and Babel doesn't spot the error on compilation.
#1334 1316086680000000 dread cset:b01de680bf86 copes with the problem. Now to find out why revision.packages has some None values - very odd!
#1334 1319798961000000 dread I think this has been a problem since 1.3.3. Fixed in v1.5.
#1335 1315910117000000 dread Done to a basic extent in branch feature-1211-drupal for release 1.4.3. Further tickets: * #1322: Action API improvements * #1315: Document /api/action
#1338 1316951545000000 amercader Reopening, because another change is needed to support custom schemas
#1338 1317117738000000 amercader Fixed in eca1edce3a0f
#1339 1316010607000000 kindly I have fixed the isodata and made a slightly modified int_converter for this case. In the correct place and raises invalids on not being an int. cset:a4af115116bb The thinking was that the input of these fields would be through the api so the empty string case did not arise. These should clearly be converted to None (Null). What issues in general? Having done this lots of times before you always end up needing to write your own little validators as the standard ones never do what you want. Thats the point of them. Look in ckan/lib/validators if you need examples. So what you did was correct...
#1340 1315991534000000 dread Fixed in default in cset:33856d3ce84e aimed at release 1.5
#1341 1315996368000000 kindly This was run to delete the users and their mistaken revisions that where created. {{{ BEGIN; delete from revision r where r.id in ( select r.id from "user" join revision r on r.author = "user".name left join resource_revision rr on rr.revision_id = r.id left join package_revision pr on pr.revision_id = r.id left join group_revision gr on gr.revision_id = r.id where "user".created between '2011-08-15' and '2011-09-06' and gr.id is null and rr.id is null and pr.id is null and ("user".name similar to '%[0-9]' or "user".fullname similar to '[A-Z][a-z]*[A-Z]%') and "user".name not like 'http%' ); delete from "user" u where u.id in ( select "user".id from "user" left join revision r on r.author = "user".name where r.id is null and "user".created between '2011-08-15' and '2011-09-06' and ("user".name similar to '%[0-9]' or "user".fullname similar to '[A-Z][a-z]*[A-Z]%') and "user".name not like 'http%' ); COMMIT; }}}
#1341 1319649573000000 dread The majority of our 6000 users are still spammers. Can we simply elimenate those who've not made any revisions? Even if we take a few genuine users with it, these are pretty dead accounts anyway.
#1341 1319709997000000 dread Reopening - this is still a serious problem. We can't link to the user page because it is so embarrassing: http://thedatahub.org/user
#1343 1316078440000000 dread I don't think email confirmation is necessary - see discussion at #1319
#1343 1318528138000000 rgrp Remove from ckan-v1.5 since remaining non-complete items (user page improvements and modal login won't get done in v1.5.
#1344 1316078757000000 kindly fixed cset:f08215845dab
#1345 1337961353000000 nils.toedtmann This becomes an actual problem on the CKAN farm s057, see http://trac.okfn.org/ticket/1245
#1345 1338551926000000 nils.toedtmann See #2485 for workarounds containing the leak(s).
#1345 1340190737000000 ross Moved out of milestone so that it gets looked at again soon
#1345 1343215489000000 amercader See https://github.com/okfn/ckan/pull/73
#1346 1316086314000000 dread Fixed in cset:df299e69d456 on default for release 1.5. Problem exists on releases 1.4.3 - 1.3.1 and probably earlier too.
#1346 1316094632000000 dread Also Transposed to
#1347 1316094608000000 dread Fixed on cset:7c3cc0fd6ae4 on branch release-v1.4.3.1.
#1349 1316277490000000 zephod Done. cset:e074aee19923
#1350 1316624288000000 zephod Was going to reimplement an old workaround described by Friedrich, where a language.js file is served through the home controller (with appropriate settings in routing.py) and so ${_('string literals')} will be translated. See: * https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/controllers/home.py#cl-48 * https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/templates/home/language.js However the string-extraction mechanism seems geared towards Genshi templates and hacks are required to make it read a javascript file neatly (ie. without putting the *entire file* into a string for translation). A more elegant solution seems to be using an xi:include to pull in a genshi template which contains an html <script> tag. * cset:d5bf4c7ba293 Issue is resolved; strings are now translated.
#1351 1316540182000000 zephod Fixed in cset:4eebcb118b09
#1353 1317075904000000 rgrp This is not deliberate and has been fixed in #1348
#1354 1316970374000000 amercader There is no way to maintain backwards compatibility, so let's forget about it for now
#1356 1317220284000000 kindly fixed cset:1defa48097f5
#1357 1318162150000000 rgrp Code to create a test dataset for data preview: https://gist.github.com/1273560 (have not added to CKAN CLI since it seems too specialist and liable to change ...)
#1357 1318164458000000 rgrp Completed and merged into default in https://bitbucket.org/okfn/ckan/changeset/9ea072d67245
#1358 1317748211000000 dread You're gonna have massive config files if you do this! Might well be worth it though.
#1359 1321563082000000 rgrp Really annoying.
#1359 1329076613000000 rgrp I have completely overhauled the licenses repo (https://github.com/okfn/licenses), see https://github.com/okfn/licenses/issues/1 and new looking: http://licenses.opendefinition.org/ Next step is to ship the core set of licenses we need for CKAN as part of CKAN and remove the external dependency.
#1359 1329076629000000 rgrp Time so far: 0.5d
#1359 1329132464000000 rgrp Fixed, see https://github.com/okfn/ckan/commit/2f789700af9ba20ed2970674c6504be8a33401d9 Adopted http://licenses.opendefinition.org/licenses/groups/ckan.json for CKAN as the default (inlined it in code). Took longer than expected as did more work on the licenses service (which was not strictly necessary!)
#1360 1317315031000000 dread I believe zephod has removed these from the UI already. I removed them from the search code, tests, docs and provided suitable guidance in cset:5b20ae1673ea which is headed for CKAN 1.5.
#1361 1317082893000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/cb641a5151df
#1363 1317656645000000 johnglover table: task_status id entity_id entity_type task_type key value date_updated state unique(entity_id, task_type, key) example keys: last_task_id
#1364 1318199135000000 kindly fixed cset:294a0b6577b0
#1365 1319815052000000 dread Done on defect-1365-search-params for 1.5. No official releases exist with this broken
#1367 1317394273000000 dread Fixed in cset:d15d81aa63cf for
#1369 1317732684000000 zephod cset 6904048ce970 Okfn needs to accept a github pull request to make this work. Currently CKAN live-links to the raw github script for ckanjs, which must be updated.
#1369 1318165086000000 rgrp Completed and merged in https://bitbucket.org/okfn/ckan/changeset/e75158acdcfa
#1370 1325474898000000 rgrp Unsure of importance. Probably fairly low but also fairly cheap to do. However, reckon we should defer of v1.6 given what else we have.
#1370 1334674002000000 toby We can supply the following to ShareThis * st_url Specifies URL (can be shortened URL) that you would like shared * st_title Specifies title that you would like shared * st_image Specifies link to image you would like displayed in the shared content * st_summary Specifies summary text/description you wish to share currently we just have the defaults but do we want to set these?
#1370 1334674212000000 toby config options: * social.sharethis_api_key * social.sharethis_style = horizontal | vertical | large | none * social.sharethis_sites = googleplus twitter facebook email sharethis Easy to add new sites we just need the ShareThis name and a description Currently these are all site wide maybe add options for specific templates (via the template not config)
#1370 1334675681000000 toby style & sites can now be passed by individual templates
Note: See TracReports for help on using and creating reports.