Ticket #1300 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Core changes to base theme

Reported by: rgrp Owned by: rgrp
Priority: major Milestone: ckan-sprint-2011-11-07
Component: ckan Keywords: refactor
Cc: Repository: ckan
Theme: none

Description (last modified by rgrp) (diff)

Core changes to theme in order to make it easier to re-theme:

  • page_heading
  • side bar menu must be switchable (left to right) (through config or css)
  • Add optional_footer to complement optional_head
    • And adopt rule for template writers that all extra js must go in optional footer
    • That way we could move optional js to the bottom of the page to improve page load times.
  • Re-add support for body-class ... (seems to be removed by #1108)
  • more divs.
  • better labelling for css (and javascript)

Change History

comment:1 Changed 3 years ago by rgrp

  • Priority changed from minor to major
  • Description modified (diff)
  • Summary changed from Expand optional head to optional css and optional js to Core changes to base theme

comment:2 Changed 3 years ago by rgrp

  • Description modified (diff)
  • Milestone changed from ckan-backlog to ckan-current-sprint

page_heading and optional_footer done in #1108

comment:3 Changed 3 years ago by rgrp

  • Description modified (diff)

comment:4 Changed 3 years ago by rgrp

Move of js to optional_footer done in cset:dcb21f0d976f. As part of #1294 have done a lot of css adding. Not sure how much more to do here.

comment:5 Changed 3 years ago by rgrp

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from ckan-current-sprint to ckan-sprint-2011-11-07

Side bar menu is switchable (though not sure how -- zephod has done this!) CSS tidying and labelling of divs done in #1380. So closing!

Note: See TracTickets for help on using tickets.