Ticket #1074 (closed enhancement: fixed)
Refactor authz web user interface to have common code and templating
| Reported by: | rgrp | Owned by: | rgrp |
|---|---|---|---|
| Priority: | major | Milestone: | ckan-v1.5 |
| Component: | ckan | Keywords: | |
| Cc: | Repository: | ckan | |
| Theme: | none |
Description (last modified by johnlawrenceaspden) (diff)
Currently repeat the same template and code across Package Authz, Group Authz, and Authz Group authz.
Having now implemented a new, cleaner setup in ckanext-admin we should port this back into core.
- Common template code (checkbox template)
- Logic code (or just common code) for wiring into authz system
- Look for all places thoroughout the system where usernames, authzgroups or groups need to be typed into boxes, and make sure that they auto-complete appropriately.
Will also deliver a significant improvement in the form of ajax user lookup.
Change History
comment:3 Changed 3 years ago by johnlawrenceaspden
- state set to draft
- Milestone changed from ckan-v1.4-sprint-6 to ckan-v1.5-sprint-1
comment:5 Changed 3 years ago by rgrp
- Owner changed from johnlawrenceaspden to rgrp
- Status changed from accepted to assigned
johnlawrenceaspden did quite a bit on this in feature-1074-refactor-authz-wui branch (including implementing for package and group). However, did not implement for authzgroup and also repeated code a lot. Reassigning to me for completion.
comment:6 Changed 3 years ago by rgrp
Also work on branch feature-1074-authz-wui (that is primary one in fact)
comment:7 Changed 3 years ago by rgrp
- Status changed from assigned to closed
- Resolution set to fixed
Closed in cset:18a5b48bbee6. Note the templating isn't completely reused but rather uses common methods from _util.html. Likely that a bit more refactoring could be done to share common code but not worth it at present.
