Ticket #1183 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Downloads "Preview" button doesn't preview.

Reported by: nickstenning Owned by: johnglover
Priority: awaiting triage Milestone: ckan-sprint-2011-10-28
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none

Description

The "Preview" button is a nice idea, but it doesn't seem to actually "preview" anything if the file MIME type would ordinarily cause the browser to download the file. If so, the browser does indeed just download the file.

This is notable in the context of most hosted file services (including Google Storage) which will deliberately serve a MIME type of application/x-some-junk-here in order to force a download.

Change History

comment:1 Changed 3 years ago by thejimmyg

  • Owner set to johnglover
  • Status changed from new to assigned
  • Milestone set to ckan-current-sprint

Hi John,

Can you have a look at this one too please?

Cheers,

James

comment:2 Changed 3 years ago by johnglover

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in new datapreview code (currently running on the test.ckan.net), which now gets the preview data from a webstore instead of the dataproxy API. It also only now shows a preview button for resources that were successfully archived and saved in the webstore.

Note: See TracTickets for help on using tickets.