Ticket #1284 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Lots of revisions being created on datahub.org

Reported by: rgrp Owned by: dread
Priority: critical Milestone:
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none


Revisions aren't assigned to packages. Where are they coming from? This seems to have been occurring since the upgrade to 1.4.3b a couple of weeks ago?

Change History

comment:1 Changed 3 years ago by dread

Fixed by rgrp in cset:1952445d2802 on release-v1.4.3 and default. Comment:

do not create revision for changes to users as they are not revisioned.

  • This had already been removed in cset:8d6fde0e2196 (then in user controller) but Adria seems to have reinstated this when refactoring things into the logic layer. This 'bug' explains the huge number of empty revisions we have been seeing on ckan.net.

comment:2 Changed 3 years ago by dread

  • Status changed from new to closed
  • Resolution set to fixed

I've added tests for this (to prevent yet another regression!) in cset:1b77ce8ce560. Closing.

comment:3 Changed 3 years ago by rgrp

I'm not sure this is the sort of thing we need tests for (we can have too many tests!). Something worse discussing ...

comment:4 Changed 3 years ago by dread

Really? How many times do you want to fix this bug again? For the sake of three lines of test...

Note: See TracTickets for help on using tickets.