Ticket #1387 (closed defect: fixed)
Not specifying a protocol in dataset url causes broken link to be served on dataset view page
Reported by: | johnglover | Owned by: | toby |
---|---|---|---|
Priority: | awaiting merge | Milestone: | ckan-v1.8 |
Component: | ckan | Keywords: | |
Cc: | Repository: | ckan | |
Theme: | none |
Description
If a user enters a url with no protocol (eg: www.data.gov.uk) in the 'url' field of a dataset, a broken link is created on the view page.
CKAN should probably either put in a http:// if no protocol is given, or validation should fail.
Change History
Note: See
TracTickets for help on using
tickets.
I'm generally against validation. When doing any bulk import, it either have to ignore validation errors or lose data. If you ignore the errors, you find you can't edit the dataset without correcting the validation error, and you often end up guessing, just to get your other changes in. All in all, I think it is better to nudge users, with javascript pop-ups in the form, or quality scores, rather than hard-and-fast validation.