Ticket #1387 (closed defect: fixed)

Opened 3 years ago

Last modified 22 months ago

Not specifying a protocol in dataset url causes broken link to be served on dataset view page

Reported by: johnglover Owned by: toby
Priority: awaiting merge Milestone: ckan-v1.8
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none


If a user enters a url with no protocol (eg: www.data.gov.uk) in the 'url' field of a dataset, a broken link is created on the view page.

CKAN should probably either put in a http:// if no protocol is given, or validation should fail.

Change History

comment:1 Changed 3 years ago by dread

I'm generally against validation. When doing any bulk import, it either have to ignore validation errors or lose data. If you ignore the errors, you find you can't edit the dataset without correcting the validation error, and you often end up guessing, just to get your other changes in. All in all, I think it is better to nudge users, with javascript pop-ups in the form, or quality scores, rather than hard-and-fast validation.

comment:2 Changed 3 years ago by rgrp

  • Milestone changed from ckan-v1.5 to ckan-v1.6

This won't happen in v1.5.

comment:3 Changed 2 years ago by johnglover

  • Milestone changed from ckan-v1.7 to ckan-v1.8

comment:4 Changed 23 months ago by toby

  • Owner set to toby
  • Status changed from new to assigned

comment:5 Changed 22 months ago by toby

  • Priority changed from minor to awaiting merge
  • Status changed from assigned to accepted

comment:6 Changed 22 months ago by toby

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.