Ticket #1517 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Accessing resource view sometimes auto-downloads the resource

Reported by: zephod Owned by: zephod
Priority: awaiting triage Milestone: ckan-sprint-2011-12-05
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none

Description

Clicking any of the links to a resource page in the dataset viewer seems to load the page and immediately start downloading the resource file.

For example, being here: ​http://test.ckan.net/dataset/europeana-lod and clicking on any of the links to the first resource.

Change History

comment:1 Changed 2 years ago by zephod

  • Status changed from new to closed
  • Resolution set to fixed

After some research, I've decided to disable the iframe datapreview of unknown filetypes. We need a safer mechanism for verifying that it's a text file or web page; a blacklist of filetypes which won't be iframed (GZIP, ZIP, etc) will never be adequate, and accidently starting a binary file download is a dangerous thing.

The fix is simple - commit: 17f33031f5e348e623146601f830b8c67462fe00

But more work will be required to relax this restriction.

Note: See TracTickets for help on using tickets.