Ticket #1553 (closed defect: fixed)

Opened 2 years ago

Last modified 22 months ago

Upload handles non-logged in user badly

Reported by: dread Owned by: aron.carroll
Priority: major Milestone: demo phase 5
Component: ckan Keywords: demo-theme
Cc: Repository: ckan
Theme: none


When you install ckanext-store (Storage extension) then CKAN displays 'Upload a file' button in the dataset/resource edit tab.

If you are not logged in, then this feature doesn't work, but there is nothing to indicate this. The button should be disabled.

Furthermore, it lets you think you are starting the upload process, the spinner spins, it says 'Uploading...' and stays like that for a long while.

This is a problem CKAN 1.4.3(ish) - 1.5.1 (current version) when you install the current ckanext-storage.

Change History

comment:1 Changed 2 years ago by dread

This is now ameliorated in thedatahub.org by requiring login to do any edits. But the bug may be an issue for other sites that want more open settings.

comment:2 Changed 2 years ago by ross

I think this is caused by the javascript xhr call getting redirected (quietly) to the login page, so the original javascript can't complete as it has a login form rather than the auth form it is looking for.

Maybe we should change the JS to realise that it is at the login page and do something different than pretend to still be uploading?

comment:3 Changed 2 years ago by rgrp

@ross: this is indeed the issue (and I explained this to dread but failed to note here). I suggested this was a limited problem as most sites would not allow anonymous editing (which is where this occurs). However, it is a UX bug for that situation.

comment:4 Changed 2 years ago by ross

  • Milestone set to ckan-v1.8

comment:5 Changed 23 months ago by ross

  • Owner changed from ross to aron.carroll
  • Status changed from new to assigned

Aron, can I assign this to you for when you do the JS based uploading on demo site/new UI?

comment:6 Changed 23 months ago by aron.carroll

  • Keywords demo-theme added
  • Milestone changed from ckan-v1.8 to opendatasuite 2

Ross, I think you just did :) I'll make sure the new form takes this into account.

comment:7 Changed 22 months ago by aron.carroll

  • Milestone changed from opendatasuite 2 to demo phase 3

comment:8 Changed 22 months ago by aron.carroll

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in d41af4c

Note: See TracTickets for help on using tickets.