Naming of a new package/group can clash with a route

[ross]

It is possible to create a group or a dataset called new, or edit, which will then be inaccessible as it is blocked by the existing routes with those names.

We should maintain a list of invalid names in the verification that happens behind the scenes in the UI.

[ross]

Potentially valid diff, needs test + patch when I have time.

--- a/ckan/controllers/api.py +++ b/ckan/controllers/api.py @@ -592,6 +592,8 @@ class ApiController?(BaseController?):

def is_slug_valid(self):

slug = request.params.get('slug') or slugtype = request.params.get('type') or

+ if slug in ['new', 'edit', 'search']: + return self._finish_ok( dict(valid=False) )

if slugtype==u'package':

response_data = dict(valid=not bool(package_exists(slug))) return self._finish_ok(response_data)

[dread]

Probably better in the ckan/logic/validators.py: name_validator