Ticket #1829 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Changing back to English prints the flash message in the previous non-English language

Reported by: dread Owned by: dread
Priority: major Milestone: ckan-sprint-2012-03-05
Component: ckan Keywords: [0.5d] [a0.1d]
Cc: seanh Repository: ckan
Theme: none

Description

On the homepage click "francais" and then "English". The flash message reads "Le langage a été fixé à: français" when it should say "The language is now: English".

Change History

comment:1 Changed 2 years ago by dread

  • Cc seanh added
  • Status changed from new to closed
  • Resolution set to fixed

This was due to ​https://github.com/okfn/ckan/commit/f07bfdb9#diff-1 - string "Language has been set to: English" shouldn't have been translated. I've put in a patch to make the code intentions clearer and added a test: [release-v1.6 07d3a02]. This only affected the 1.6 beta, and is fixed for the release.

comment:2 Changed 2 years ago by dread

  • Keywords [a0.1d] added
Note: See TracTickets for help on using tickets.