Ticket #242 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Miscellaneous tidying up (v0.11)

Reported by: rgrp Owned by: pudo
Priority: critical Milestone: v1.1
Component: ckan Keywords: search size-s
Cc: Repository:
Theme:

Description (last modified by rgrp) (diff)

Dumping ground for various minor and miscellaneous items (mainly refactorings):rgrp

  • controllers/tag.py: why does this not use lib/search.py (but controllers/packages.py search method does)?

done:

  • lib/search.py: inheritance would be nicer than switching on entity in search (i.e. have SearchPackage?, SearchTag? etc)

Change History

comment:1 Changed 4 years ago by rgrp

  • Owner changed from rgrp to dread
  • Priority changed from awaiting triage to critical
  • Milestone set to v1.1

comment:2 Changed 4 years ago by pudo

  • Description modified (diff)

item 1 is done with the refactoring

comment:3 Changed 4 years ago by rgrp

  • Owner changed from dread to pudo
  • Description modified (diff)
  • Milestone v1.1 deleted

comment:4 Changed 4 years ago by rgrp

  • Milestone set to v1.1

comment:5 Changed 4 years ago by pudo

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in cset:1393

In the long run, we'll want to remove those SQL-based search from the search code. The upside to using the search backend right now is that we pipe things through the query parser, which means multiple terms are looked up properly. Not a big gain.

Note: See TracTickets for help on using tickets.