Ticket #2500 (closed defect: fixed)

Opened 2 years ago

Last modified 23 months ago

get_action should raise an exception if the action requested doesn't exist

Reported by: icmurray Owned by: ross
Priority: awaiting merge Milestone: ckan-v1.8
Component: ckan Keywords:
Cc: Repository: ckan
Theme: none

Description

Original bug report:

Hi CKAN devs,

Can I request that ckan.logic.get_action raises an exception if the action requested doesn't exist?

Two of us had a frustrating time tracking down an exception this morning. It's difficult when the exception is raised in python in a template because you don't get a line number. The problem was caused by a new logic function being added to another extension, and we hadn't updated the code there. So if get_action raised an proper exception rather than silently returning None then I think we'd have found the problem quicker.

I'd write the code for this, but as I understand that the new system would require a ticket, branch, pull request, code review, merge. It seems a lot to do for such a small thing.

Dave

Change History

comment:1 Changed 23 months ago by ross

  • Owner set to ross
  • Status changed from new to accepted

comment:2 Changed 23 months ago by ross

  • Priority changed from awaiting triage to awaiting merge

comment:3 Changed 23 months ago by icmurray

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.