Ticket #270 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Refactor ckan/lib/importer and ckanclient/loader.

Reported by: johnbywater Owned by: johnbywater
Priority: awaiting triage Milestone:
Component: ckan Keywords:
Cc: Repository:
Theme:

Description (last modified by johnbywater) (diff)

There is code to create packages in-process (ckan/lib/importer) and via HTTP (ckanclient/loaders/base). There is also code to read different kinds of package source (Google Spreadsheets spreadsheet, other spreadsheet).

Propose to refactor all this to have template method in base command class (subclasses may implement command line interface, graphical user interface, or Web interface), where the template method calls on aggregated strategy objects for: reading raw spreadsheet data from spreadsheet application; for inferring CKAN package entities from the raw spreadsheet data; and for writing package entities to CKAN service.

Spreadsheet readers to be factored to allow for variations of spreadsheet application.

Raw data inferrers to allow for variations in spreadsheet cell structure.

CKAN writer strategies to allow for either CKAN client or direct linking.

Actual cases then supported by specifying existing strategies (or defining new ones) in a script that invokes the command class.

Change History

comment:1 Changed 4 years ago by johnbywater

  • Description modified (diff)

comment:2 Changed 4 years ago by johnbywater

  • Description modified (diff)

comment:3 Changed 3 years ago by dread <[email protected]…>

  • Status changed from new to closed
  • Resolution set to fixed

Nearly everything mentioned here has been achieved with the SpreadsheetData?, DataRecords?<-SpreadsheetDataRecords?, PackageImporter?<-SpreadsheetPackageImporter? design. New imports can take advantage of this.

Note: See TracTickets for help on using tickets.