Ticket #2710 (closed enhancement: fixed)
make the api_info.html not look like shit
| Reported by: | toby | Owned by: | tobes |
|---|---|---|---|
| Priority: | minor | Milestone: | demo phase 3 |
| Component: | ckan | Keywords: | demo-theme |
| Cc: | shevski | Repository: | ckan |
| Theme: | none |
Description
you know the score
Change History
comment:1 Changed 22 months ago by aron.carroll
- Status changed from new to closed
- Resolution set to fixed
comment:2 Changed 22 months ago by toby
- Status changed from closed to reopened
- Resolution fixed deleted
- Milestone changed from demo phase 2 to demo phase 3
@aron,
we need to have this styled a little better when non-js user
maybe it needs a little thought so that the lightbox gets a snippet and the non-js user gets the snippet embedded in a page so consisten styling and looks like part of ckan
comment:4 Changed 22 months ago by toby
@aron
I've done this - it needs a bit of work ie breadcrumb and you won't like what I did with the css classes/js- a better solution is needed but this gives a quick example that we can improve on
let me know your thoughts
https://github.com/okfn/ckan/commit/cec57f36094327611ff9bc8935c061a61ca3e961
comment:5 Changed 22 months ago by aron.carroll
- Owner changed from aron.carroll to tobes
- Priority changed from awaiting triage to minor
- Status changed from reopened to assigned
Fixed this up, assigning back to you for one small issue. The h.url_for('datastore_read') is returning a broken url:
https://github.com/okfn/ckan/blob/2710-nicer-api-page/ckan/controllers/package.py#L1139-1140
It looks like this:
http://localhost:5000datastore_read?id=794dab29-703f-4ab5-9043-ace58c87a2ce
Displayed in a lightbox as of f347f11