Ticket #2734 (closed enhancement: fixed)

Opened 22 months ago

Last modified 22 months ago

once format on resource form has errored, no longer submits form

Reported by: shevski Owned by: toby
Priority: critical Milestone: demo phase 2
Component: ckan Keywords: demo-theme
Cc: Repository: ckan
Theme: none

Description (last modified by shevski) (diff)

Steps to reproduce:

  1. go to edit a resource, e.g. http://s031.okserver.org:2375/dataset/ted/resource_edit/a621a6ad-6f1c-46d1-b858-03cdb7a25c07
  1. Change the format field to something it doesn't get. e.g. add a comma "HTML,"
  1. Get message: "The form contains invalid entries:

Last modified: Date format incorrect Size: Invalid integer"

  1. Format field reverts, try to re-save/submit form - i.e. click on "update resource"
  1. nothing happens (same if you even try changing the format field

Change History

comment:1 Changed 22 months ago by shevski

  • Description modified (diff)

comment:2 Changed 22 months ago by toby

  • Status changed from new to closed
  • Resolution set to invalid

Shevski,

I think this is an old dataset it works fine with new ones. I think this is a corrupt data issue.

also HTML, is fine as a format

please reopen if you can reproduce with a dataset that has been created since the update today

comment:3 Changed 22 months ago by shevski

  • Status changed from closed to reopened
  • Resolution invalid deleted

I did this with a dataset I just created, 5 mins before creating this ticket Tried it again with a new datasrt, happened again. It's when you're editing a resource

comment:4 Changed 22 months ago by toby

@ira,

can you try to work out exactly how to cause this problem starting with add a dataset and let me know how you break things

tell me all the fields you filled in - also try to get it to happen using as little effort as possible eg add dataset http://s031.okserver.org:2375/dataset/new

title = mooooo

click next:add data

resource = moo format = csv

click save & add another

click on resource just created in sidebar to edit

change format to HTML,

click Save & add another

etc

that all works fine for me what am i doing wrong? thanks

also please try using a non sysadmin account

comment:5 Changed 22 months ago by toby

  • Owner changed from toby to shevski
  • Priority changed from awaiting triage to critical
  • Status changed from reopened to assigned

comment:6 Changed 22 months ago by shevski

  • Owner changed from shevski to toby

Wierd. It always breaks for me. Maybe we go through this on skype. I just did it with a non-admin account.

Steps:

  1. Create new dataset. Name whatever, resource it a link (I use http://trac.ckan.org/ticket/2734) e.g. http://s031.okserver.org:2375/dataset/format-error-test
  2. Once you've *finished* the dataset creation process you are on the main dataset page. Click on the resource you added.
  3. Click on "edit"
  4. Change resource field to "html," for example and click on "update resource"
  5. Error shows, clicking on "update resource" doesn't do anything.

How about I do it and you watch via screen share?

comment:7 Changed 22 months ago by toby

cool I can reproduce fix will be today

comment:8 Changed 22 months ago by toby

  • Status changed from assigned to closed
  • Resolution set to fixed

@ira,

fixed and uploaded to s031 re-open if still broken

comment:9 Changed 22 months ago by shevski

ace!

Note: See TracTickets for help on using tickets.