Ticket #2749 (closed enhancement: fixed)

Opened 22 months ago

Last modified 22 months ago

page title issue with super() super()

Reported by: toby Owned by: aron.carroll
Priority: awaiting triage Milestone: demo phase 5
Component: ckan Keywords: demo-theme
Cc: Repository: ckan
Theme: none

Description

title broken for

http://s031.okserver.org:2375/en/dataset/new_resource/gold-prices

we have inherited the title from the extended page not from the base

should be 'add data - ckan' not 'add data - create dataset - ckan'

any idea how we fix this?

Change History

comment:1 Changed 22 months ago by aron.carroll

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in 27af570. Fix was simple just don't define a title in the base template. An alternative would have been to wrap the title portion in a block

{% block title %}{% block page_title %}My Subtitle{% endblock %} - {{ super() }}{% endblock %}

comment:2 Changed 22 months ago by toby

I like the block page_title approach but not too fussed as long as this instance is working

Note: See TracTickets for help on using tickets.