Ticket #2765 (closed enhancement: fixed)

Opened 21 months ago

Last modified 21 months ago

Demo login error messages

Reported by: aron.carroll Owned by: aron.carroll
Priority: minor Milestone: demo phase 3
Component: ckan Keywords: demo-theme
Cc: Repository: ckan
Theme: none


I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.

So in general, provide an error dict

Change History

comment:1 Changed 21 months ago by toby

  • Owner changed from toby to aron.carroll
  • Status changed from new to assigned


I've added a data summary

The data errors for empty fields are not happening due to our use of repoze.who for logins which is crap and doesn't provide feedback re loggin details so not possible without hacking repoze which i'm not doing.

Could you look at cleaning up the error summary we don't supply a field name (key) as not relevant it would be nice if we could hide the : also removing the invalid fields message would be good to hide maybe add this as an option to the macro

comment:2 Changed 21 months ago by aron.carroll

  • Status changed from assigned to closed
  • Resolution set to fixed

Cool, closed as of 99b8c4f. I fixed the error summary display and highlighted the fields in red to show they were incorrect.

Note: See TracTickets for help on using tickets.