Ticket #576 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

CKAN Requires Old Version of SQLAlchemy

Reported by: wwaites Owned by: sebbacon
Priority: major Milestone: ckan-v1.3
Component: ckan Keywords:
Cc: Repository:


Requires 0.4. 0.5 is a maintenance branch, 0.6 is current.

VDM appears to work correctly (all the tests pass) with 0.5. CKAN does not -- requires more investigation to determine exactly why.

It would actually be nice to be able to run with 0.6 or 0.5, though 0.6 will require some changes to VDM as well

Change History

comment:1 Changed 4 years ago by wwaites

  • cset:9b1255e02e5e removes a reference to Package.c which is deprecated even in 0.4
  • cset:d7e583948c95 wraps the session creation in if/else block on SQAlchemy version as the default behaviours and options have changed

Unit Tests appear to work as before... Boy do they take a long time to run...

comment:2 Changed 4 years ago by wwaites

cset:7a04e78cec97 pool_threadlocal=True is no longer the default with 0.5. Setting it to False (the default) causes unit tests to hang. So explicitly set it to True to retain compatibility. It is an open question whether this is the correct setting, the defaults were changed as apparently they led to surprising behaviour. One hopes that our unit tests have already eliminated any such surprises.

comment:3 Changed 4 years ago by wwaites

Most of the way to 0.6 compatibility with cset:ce6b870570c1/vdm

All tests still pass with 0.4 and 0.5

comment:4 Changed 3 years ago by rgrp

  • Owner set to seb.bacon
  • Component set to ckan

comment:5 Changed 3 years ago by rgrp

  • Owner changed from seb.bacon to sebbacon

comment:6 Changed 3 years ago by dread

  • Status changed from new to closed
  • Resolution set to fixed

Seb's completed this now I believe. It's merged into head CKAN cset:68d63fda4814.

Note: See TracTickets for help on using tickets.