Ticket #736 (closed requirement: fixed)

Opened 4 years ago

Last modified 3 years ago

URL validation for CSW and WMS links

Reported by: johnbywater Owned by: amercader
Priority: minor Milestone: ckan-v1.4-sprint-7
Component: uklii Keywords:
Cc: Repository: ckan
Theme: none

Description

Robust against slightly incorrect URLs (e.g. with trailing slash, or without /csw), and non-CWS service which also return <ows:ExceptionReport ... />.

Both cases would be resolved by checking capabilities (with CswClient's check_get_capabilities() method).

Change History

comment:1 Changed 3 years ago by thejimmyg

  • Owner changed from johnbywater to thejimmyg
  • Priority set to minor
  • Component set to uklii
  • Type changed from story to requirement

comment:2 Changed 3 years ago by thejimmyg

  • Summary changed from Robust CSW harvest source detection to Robust CSW harvest source detection and tests

The tests we write for this would need to:

  • Submit harvest source form with valid CSW location
  • Submit harvest source form with invalid CSW location

We can now close #790 and #791. Note that discussion on end-to-end testing is now at #784.

comment:3 Changed 3 years ago by thejimmyg

  • Summary changed from Robust CSW harvest source detection and tests to URL validation for CSW and WMS links

We also need to check WMS URLs added to package resources to check they are genuine WMSs.

comment:4 Changed 3 years ago by thejimmyg

  • Status changed from new to assigned
  • Theme set to none
  • Repository set to ckan
  • state set to draft
  • Milestone set to ckan-v1.4-sprint-7
  • Owner changed from thejimmyg to amercader

We now check WMS links. The CSW link checking could be more robust. New proposal is:

Check that a URL with a / is treated the same way as one without. Treated as the same if same port, scheme, domain and path (ie query string and fragment are ignored, port is normalised away)

Note: See TracTickets for help on using tickets.