Ticket #930 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

call_timing files created for every request

Reported by: dread Owned by: wwaites
Priority: major Milestone:
Component: ckan Keywords:
Cc: Repository:
Theme:

Description

On a production server we produce literally millions of little files saying how long every single request took to process.

They are here:

hmg.ckan.net.2/pylonsdata/call_timing

They were added by ckan/lib/base.py in cset:da438a9085d3.

I don't believe anyone uses these stats.

Change History

comment:1 Changed 3 years ago by wwaites

  • Owner set to wwaites
  • Status changed from new to assigned

comment:2 Changed 3 years ago by wwaites

This is for HMG to prove to them that requests are being serviced in a timely manner

  • move this functionality to a plugin
  • make it use rrdtool instead of lots of itty bitty files

comment:3 Changed 3 years ago by wwaites

  • Status changed from assigned to closed
  • Resolution set to fixed

actually, this is a configuration variable ckan.enable_call_timing

cleaned up the code a bit, make sure this variable unset or set to false or no and there should be no millions of files

as it is unclear if this is actually used or necessary, not doing the rrdtool part just yet. if there is call for it, make a new ticket for this.

comment:4 Changed 3 years ago by rgrp

Just want to agree with wwaites assessment here. dubious this code is currently useful as a) not used b) (more importantly) probably better ways to achieve this functionality.

Note: See TracTickets for help on using tickets.