Ticket #962 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Improvements to data preview extension

Reported by: rgrp Owned by: rgrp
Priority: critical Milestone: ckan-v1.4-sprint-5
Component: ckan Keywords: extension
Cc: Repository: ckan
Theme: none


Basic implementation done (and deployed):


However plenty to improve, e.g.

  • Support more formats (use external systems for preview?)
    • json (!)
    • html (trivial!)
    • sparql
    • ...
  • Do not display preview if no preview

Also suggest reworking to use external services rather than doing preview 'in house' (doing in house places heavy reliance on data proxy service and on converting data to a standard format).

Change History

comment:1 Changed 3 years ago by rgrp

  • Milestone changed from ckan-v1.4-sprint-1 to ckan-v1.4-sprint-2

In progress but not yet completed so moving to next sprint. Estimate remaining time at: 2h.

comment:2 Changed 3 years ago by rgrp

  • Milestone changed from ckan-v1.4-sprint-2 to ckan-v1.4-sprint-3

Nearly done.

comment:3 Changed 3 years ago by rgrp

  • Owner changed from rgrp to thejimmyg
  • Repository set to ckan
  • Theme set to none
  • Milestone changed from ckan-v1.4-sprint-3 to ckan-v1.4-sprint-4

comment:4 Changed 3 years ago by thejimmyg

  • Milestone changed from ckan-v1.4-sprint-4 to ckan-v1.4-sprint-5

comment:5 Changed 3 years ago by rgrp

  • Owner changed from thejimmyg to rgrp

comment:6 Changed 3 years ago by rgrp

  • Status changed from new to closed
  • Resolution set to fixed

Closing as have now reworked to:

  • Support plain text previews for many formats (including xml based formats)
  • Try to handle everything else as html with an iframe ...
  • Do not show preview button where not useful
  • Normalize formats for better recognition (e.g. text/csv, application/xls)

See: https://bitbucket.org/okfn/ckanext-datapreview/changeset/c1d672a6c368 and previous.

Also re-updated the dataproxy so it works again (had got out of sync when mistakenly reverted the dataproxy a couple of weeks ago).

Could still do api/sparql (using sparql js wrapper) and handle json (as plain text ...?) but these can be new tickets.

Note: See TracTickets for help on using tickets.